-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support filtering options for eth_subscribe
with logs
#27842
Labels
feature/web3/wallet/core
feature/web3/wallet
Integrating Ethereum+ wallet support
OS/Android
Fixes related to Android browser functionality
OS/Desktop
OS/iOS
Fixes related to iOS browser functionality
priority/P4
Planned work. We expect to get to it "soon".
QA Pass - Android ARM
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Comments
vadimstruts
added
OS/macOS
OS/Windows
QA Pass-macOS
feature/web3/wallet
Integrating Ethereum+ wallet support
OS/Android
Fixes related to Android browser functionality
OS/Desktop
OS/iOS
Fixes related to iOS browser functionality
OS/macOS-arm64
OS/ChromeOS
feature/web3/wallet/core
OS/Windows-arm64
labels
Jan 16, 2023
vadimstruts
removed
OS/ChromeOS
OS/macOS
OS/Windows
OS/macOS-arm64
OS/Windows-arm64
labels
Jan 16, 2023
25 tasks
25 tasks
Verification passed on
27842.mp4Verification passed on Oppo Reno 5 with Android 13 running 1.50.93 x64 Beta build
27842-Android.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/web3/wallet/core
feature/web3/wallet
Integrating Ethereum+ wallet support
OS/Android
Fixes related to Android browser functionality
OS/Desktop
OS/iOS
Fixes related to iOS browser functionality
priority/P4
Planned work. We expect to get to it "soon".
QA Pass - Android ARM
QA Pass-Win64
QA/Yes
release-notes/include
Description
The issue is a follow up of: #27283 - Support eth_subscribe with "logs" param
For now we support only this:
window.ethereum.on('message', (x, y, z) => console.log('message event: ', x, y, z)) window.ethereum.send({ id:5, method: 'eth_subscribe', params:["logs"]}, console.log)
But we need to extend the eth_subscribe subscription for method: "logs" with filtering options support.
Ex.:
Here is options that can be supported according with: eth_getLogs
fromBlock
- (optional, default: "latest") Integer block number encoded as a hexadecimal or the string, "latest", "pending", and "earliest".toBlock
- (optional, default: "latest") Integer block number encoded as a hexadecimal or the string, "latest", "pending", and "earliest".address
- (optional) Contract address or a list of addresses from which logs should originate.topics
- (optional) Array of DATA topics. Topics are order-dependent. Visit this Wiki page to learn more about topics.blockHash
- (optional) With the addition of EIP-234, blockHash is a new filter option that restricts the logs returned to the block number referenced in the blockHash. Using the blockHash field is equivalent to setting the fromBlock and toBlock to the block number the blockHash references. If blockHash is present in the filter criteria, neither fromBlock nor toBlock is allowed.Steps to Reproduce
Actual result:
when you try ti subscribe for logging with filtering options, you get an error:
Expected result:
Successful subscription result:
and filtering options are applied.
Reproduces how often:
Easily reproduced
Desktop Brave version:
1.49.27 Chromium: 109.0.5414.87 (Developer Build) (64-bit)
The text was updated successfully, but these errors were encountered: