Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ramp as an Offramp Provider #27872

Closed
Douglashdaniel opened this issue Jan 17, 2023 · 2 comments · Fixed by brave/brave-core#17119
Closed

Add Ramp as an Offramp Provider #27872

Douglashdaniel opened this issue Jan 17, 2023 · 2 comments · Fixed by brave/brave-core#17119
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@Douglashdaniel
Copy link

Description

Add Ramp as an Offramp Provider
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jan 17, 2023
@Douglashdaniel Douglashdaniel self-assigned this Jan 17, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Jan 17, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Feb 9, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Feb 9, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Feb 15, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 15, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Feb 23, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Mar 1, 2023

The above requires 1.49.117 or higher for 1.49.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Mar 3, 2023

Verification passed on

Brave 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#17119
  • Verified selecting token from Portfolio and clicking on Sell shows the confirmation modal
  • Verified able to enter a custom value or use the Half or Max presets value to auto-populate the values
  • Verified clicking on Sell with Ramp loads a new tab and loads Sell
  • Verified Address, Fiat Value, Offramp Asset and Fiat Currency is all prefilled correctly
  • Verified only supported tokens show Sell option in account view
  • Verified Sell option for supported tokens is shown on token details view and in account view
27872.mp4

@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Add Ramp as an Offramp Provider brave/brave-core
4 participants
@kjozwiak @srirambv @Douglashdaniel @brave-builds