Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-- Learn more link in Rewards overlay should go to https://brave.com/rewards-changes not https://brave.com/brave-rewards/ #27986

Closed
stephendonner opened this issue Jan 23, 2023 · 3 comments · Fixed by brave/brave-core#16816
Assignees
Labels
bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@stephendonner
Copy link

stephendonner commented Jan 23, 2023

Description

-- Learn more link in Rewards overlay (i.e., Rewards dropdown panel) should go to https://brave.com/rewards-changes not https://brave.com/brave-rewards/

Steps to reproduce

  1. installed 1.47.161
  2. launched Brave
  3. enabled Brave Rewards
  4. installed 1.48.137 atop 1.47.161 (both are beta-channel builds)
  5. launched Brave
  6. tapped the BAT icon
  7. examined and clicked on the Learn more link

Actual result

Link goes to https://brave.com/brave-rewards/

BAT-icon overlay https://www.brave.com/rewards
Screenshot_20230123-125338

NOTE: brave://rewards has the links correctly

Expected result

Link should go to https://brave.com/rewards-changes

Issue reproduces how often

100%

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86): arm64
  • Device type (Phone, Tablet, Phablet): Google Pixel XL
  • Android version: 9

Brave version

1.48.137

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

/cc @deeppandya @Miyayes @LaurenWags

@Miyayes Miyayes added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Jan 23, 2023
@Miyayes
Copy link
Collaborator

Miyayes commented Jan 23, 2023

Will need uplift to 1.48.x. @kjozwiak

@kjozwiak
Copy link
Member

The above requires 1.48.140 or higher for 1.48.x verification 👍

@stephendonner
Copy link
Author

Verified PASSED using Brave 1.48.141 on a Google Pixel XL (arm64) running Android 9

Followed my original steps to reproduce

Confirmed the link in the panel/overlay now goes to https://brave.com/rewards-changes

20230225_093456_edited.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants