Rotate the Windows update key

[mherrmann]

Description

In addition to SSL, updates on Windows are secured at the transport layer with a mechanism called CUP. The goal of this issue is to rotate the associated keys on the client side.

[LaurenWags]

@brave/qa-team we should test this on multiple Windows versions and devices, please don't add labels until all verifications are complete.

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.49.100 Chromium: 110.0.5481.100 (Official Build) beta (64-bit)
-- | --
Revision | 4be7a36f7cb943af6118e449bbab494b43dcaddd-refs/branch-heads/5481_77@{#14}
OS | Windows 10 Version 21H2 (Build 19044.2604)

• Verified the test plan from Rotate Windows update key brave-core#16886

Windows 10 x64

1. Verify installers and auto-updater work on a clean profile

Case 1: Verify the Omaha updater version when 1.49.x is installed_PASSED

Pre-requisites:
(Please note these steps are same as remove updater as described in the "Cleaning up after a test" in brave/brave-core#11096 but I have breakdown the steps into detailed)

1. Uninstall all the brave version (all channels Dev, Release, Beta and Nightly) via Control panel
2. Remove all the local profile folders from %LOCALAPPDATA%\BraveSoftware
3. Go to C:\Program Files (x86)\BraveSoftware\update path and observe that Update folder is still available and updater version 1.3.361.135 is still shown
4. Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version is 1.3.361.135
5. Open command prompt with Admin privileges and run the command "C:\Program Files (x86)\BraveSoftware\Update\BraveUpdate.exe" /uninstall
6. Go to C:\Program Files (x86)\BraveSoftware path and observe that the update folder is removed
7. Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version 1.3.361.135 is removed from the registry
8. If the registry key isn't empty in steps 6 and 7 then kill all instances of BraveUpdate.exe, BraveCrashHandler.exe, BraveCrashHandler64.exe in the Task Manager
9. Steps 6 and 7 indicate that the Omaha updater is completely uninstalled

Steps:

• Run steps 1 to 7 from Pre-requisites
• Download BraveBrowserStandaloneBetaSetup.exe and install the standalone binary 1.49.x with Admin rights and ensure that the standalone installer is installed successfully
• Confirmed that the new Omaha updater 1.3.361.137 is shown in the registry as expected
• Confirmed new Omaha updater version 1.3.361.137 is shown in C:\Program Files (x86)\BraveSoftware\Update
• Uninstall the 1.49.x from the control panel and remove the profile folder from the %LOCALAPPDATA%\BraveSoftware
• Install the 1.49.x again and confirmed that the brave was installed successfully
• Go to brave://settings/help and wait for the update and click on Relaunch and confirm that brave is upgraded to the latest public/internal version

Example	Example	Example

Case 2: Download and install stub installer binary 1.49.x with Admin rights_PASSED

• Uninstall 1.49.x from the control panel if it's installed
• Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
• Install 1.49.x stub installer BraveBrowserBetaSetup.exe and ensured that brave is installed successfully and the latest public released beta version is fetched from the Omaha server as expected
  

Case 3: Download and install standalone silent installer binary 1.49.x_PASSED

• Uninstall 1.49.x from the control panel if it's installed
• Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
• Install 1.49.x standalone silent installer BraveBrowserStandaloneSilentBetaSetup.exe and ensured that brave is installed in silent mode (Installer modal is NOT shown on the UI) and ensured that correct version details are shown brave://settings/help
  

2. Verify installers and auto-updater works on upgrade profile

Case 1:Verify the Omaha updater version in an upgraded profile (Install 1.48.128 ->upgrade to 1.49.x)_PASSED

Steps :

1. Follow the pre-requisites steps from case 1 to uninstall the Omaha
2. Install the BraveBrowserStandaloneBetaSetup.exe build version 1.48.128 (build before the Omaha updater change 1.3.361.137)
3. Confirmed build is installed successfully and version details are shown correctly in brave://settings/help
4. Confirmed that the old Omaha updater 1.3.361.135 is shown in the registry as expected
5. Confirmed old Omaha updater version 1.3.361.135 is shown in C:\Program Files (x86)\BraveSoftware\Update
6. Go to brave://settings/help and wait for the update click on Relaunch and ensure brave is updated to the latest public beta version 1.49.x

1.48.128 update to ----> 1.49.100

Example	Example	Example	Example

Though the build gets updated from 1.48.128 to 1.49.100, the Omaha updater is still showing up the older version 1.3.361.135, this is because the new updater is not yet uploaded to the production update server/not yet live, the new updater is uploaded to the staging update server hence "Background updates" run is required, the steps are mentioned below.

1. Configure your machine to pull updates from staging by setting the registry string value Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\UpdateDev\url to https://updates.brave.com/service/update2. You need to be connected to VPN to be able to access the staging update server. (To test, you can open https://updates.brave.com. If you get a 404 error, then you have access.)

2. Remove LastChecked from the Update via Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update

3. Run BraveSoftwareUpdateTaskMachineUA from the Windows Task Scheduler. Refresh with F5 until the task has ended

Once the Task Scheduler runs successfully, the Omaha updater version is updated to 1.3.361.137 in both C:\Program Files (x86)\BraveSoftware\Update and Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update

Example	Example

Case 2: Install standalone installer 1.48.x and upgrade the profile to 1.49.x_PASSED

• Uninstall 1.49.x from the control panel if it's installed
• Install standalone beta installer 1.48.128
• Go to brave://settings/help and wait for the update and click on Relaunch (Please note: remove URL parameter which is set in case 1 above, otherwise you will not see the Relaunch button in 1.48.128 )
• Confirmed that brave is upgraded to 1.49.x public released version

Example	Example

Case 3: Install standalone installer 1.48.x and upgrade the profile to 1.49.x test channel_PASSED

• Uninstall 1.49.x from the control panel if it's installed
• Install 1.48.128 standalone beta installer
• Confirmed brave 1.48.128 installed successfully
• Install the test channel BraveBrowserBetaSetup-64-be-test
• Confirmed that brave is upgraded to 1.49.x test/internal channel

Example	Example

Case 4: Install standalone silent installer 1.48.x and upgrade the profile to 1.49.x_PASSED

• Uninstall 1.49.x from the control panel if it's installed
• Install 1.48.x standalone silent beta installer
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed that brave is upgraded to 1.49.x public released version

Example	Example

3. Verify installers and auto-updater work when the user declines the Admin rights in UAC

[Note: when brave is installed for the current user (without admin rights) the Brave-Browser-Beta folder gets created under the registry path Computer\HKEY_CURRENT_USER\SOFTWARE\BraveSoftware\ and Omaha new updater version is shown as expected]

Case 1: Verify standalone installer can be installed without admin rights and updater works_PASSED

• Install the 1.49.97 beta standalone installer
• Decline the Admin rights in UAC while installing the setup
• Confirmed 1.49.97 the beta standalone installer is installed successfully
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed that the brave is upgraded to 1.49.100 beta public released version

Example	Example	Omaha 1.3.361.137

Case 2: Verify stub installer can be installed without admin rights_PASSED

• Install the beta stub installer
• Decline the Admin rights in UAC while installing the setup
• Confirmed 1.49.100 public released beta version is installed

4. Verify that re-install same installer version works

Case 1: Verify standalone installer can be installed twice and update works_PASSED

• Install the 1.49.97 standalone installer twice
• Ensured two brave windows are opened with the same version
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed that brave is updated to 1.49.100 public released version

Example	Example

Case 2: Verify stub installer can be installed twice_PASSED

• Install beta stub installer twice
• Ensured two brave windows are opened with the same version
• Go to brave://settings/help and confirmed that the 1.49.100 public released beta version is shown

Case 3: Verify standalone silent installer can be installed twice and update works_PASSED

• Install 1.49.x standalone silent installer twice
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed that brave is updated to 1.49.x public released version

Example	Example

5. Install quite older installers and check update works correctly

Case 1: Install 1.46.x and ensure upgrade works_PASSED

• Install 1.46.93.x beta build
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed 1.49.x public released version is installed

1.46.x	1.49.x

Case 2: Install 1.42.x and ensure upgrade works_PASSED

• Install 1.42.64 beta build
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed 1.49.x public released version is installed

1.42.x	1.49.x

Case 3: Install 1.40.x and ensure upgrade works_PASSED

• Install 1.40.86 beta build
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed 1.49.x public released version is installed

1.40.x	1.49.x

Case 4: Install 1.30.x and ensure upgrade works_PASSED

• Install 1.30.x beta build
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed 1.49.x public released version is installed

1.30.x	1.49.x

Case 5: Install 1.26.x and ensure upgrade works_PASSED

• Install 1.26.x beta build
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed 1.49.x public released version is installed

1.26.x	1.49.x

6. Verify that install brave works when the Internet is disconnected

Case 1: Verify standalone installer can be installed when the network is disconnected_PASSED

• Install 1.49.x standalone installer
• Confirmed standalone installer is installed successfully and version details are shown correctly
• Go to brave://settings/help and ensured the update is NOT shown which is expected as to pull the Omaha version network needs to be connected

Case 2: Verify standalone silent installer can be installed when the network is disconnected_PASSED

• Install 1.49.x standalone silent installer
• Confirmed standalone silent installer is installed successfully and version details are shown correctly
• Go to brave://settings/help and ensured the update is NOT shown which is expected as to pull the Omaha version network needs to be connected

Case 3: Verify stub installer can't be installed when the network is disconnected_PASSED

• Try installing the stub installer
• Unable to install the installer which is expected as to pull the Omaha version network needs to be connected
  

7. Verify installing a new binary by older binary from different installers (e.g one is standalone and the other is stub/silent)

Case 1: Install standalone installer 1.48.x and upgrade it by 1.49.x stub installer_PASSED

• Clean profile 1.48.x standalone installer BraveBrowserStandaloneSetup.exe
• Install the standalone installer and confirmed 1.48.x is installed successfully
• Upgrade the profile by 1.49.x stub installer BraveBrowserBetaSetup.exe
• Confirmed that the 1.49.x public releases version is installed successfully

Case 2: Install standalone silent installer 1.48.x and upgrade it by 1.49.x stub installer(decline Admin rights)_PASSED

• Clean profile 1.48.x standalone installer BraveBrowserStandaloneSilentBetaSetup.exe
• Install the standalone silent installer and confirmed 1.48.x is installed successfully
• Upgrade the profile by 1.49.x stub installer BraveBrowserBetaSetup.exe while installing decline the Admin rights
• Go to brave://settings/help and click on Relaunch
• Confirmed that the 1.49.x public releases version is installed successfully

Case 3: Install standalone silent installer 1.48.x and then autoupgrade_PASSED

• Clean profile 1.48.x standalone silent installer BraveBrowserStandaloneSilentBetaSetup.exe
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed that the 1.49.x public release version is installed successfully

Case 4: Install standalone installer 1.48.x and then autoupgrade_PASSED

• Clean profile 1.48.x standalone installer BraveBrowserStandaloneBetaSetup.exe
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed that the 1.49.x public releases version is installed successfully

---

Verification PASSED on

Brave | 1.49.106 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
-- | --
Revision | 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS | Windows 11 Version 22H2 (Build 22621.1265)

• Verified the test plan from Rotate Windows update key brave-core#16886

Windows 11 x64

1. Verify installers and auto-updater work on a clean profile

Case 1: Verify the Omaha updater version when 1.49.x is installed_PASSED

Pre-requisites:
(Please note these steps are same as remove updater as described in the "Cleaning up after a test" in brave/brave-core#11096 but I have breakdown the steps into detailed)

1. Uninstall all the brave version (all channels Dev, Release, Beta and Nightly) via Control panel
2. Remove all the local profile folders from %LOCALAPPDATA%\BraveSoftware
3. Go to C:\Program Files (x86)\BraveSoftware\update path and observe that Update folder is still available and updater version 1.3.361.135 is still shown
4. Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version is 1.3.361.135
5. Open command prompt with Admin privileges and run the command "C:\Program Files (x86)\BraveSoftware\Update\BraveUpdate.exe" /uninstall
6. Go to C:\Program Files (x86)\BraveSoftware path and observe that the update folder is removed
7. Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version 1.3.361.135 is removed from the registry
8. If the registry key isn't empty in steps 6 and 7 then kill all instances of BraveUpdate.exe, BraveCrashHandler.exe, BraveCrashHandler64.exe in the Task Manager
9. Steps 6 and 7 indicate that the Omaha updater is completely uninstalled

Steps:

• Run steps 1 to 7 from Pre-requisites
• Download BraveBrowserStandaloneBetaSetup.exe and install the standalone binary 1.49.x with Admin rights and ensure that the standalone installer is installed successfully
• Confirmed that the new Omaha updater 1.3.361.137 is shown in the registry as expected
• Confirmed new Omaha updater version 1.3.361.137 is shown in C:\Program Files (x86)\BraveSoftware\Update
• Uninstall the 1.49.x from the control panel and remove the profile folder from the %LOCALAPPDATA%\BraveSoftware
• Install the 1.49.x again and confirmed that the brave was installed successfully
• Go to brave://settings/help and wait for the update and click on Relaunch and confirm that brave is upgraded to the latest public/internal version

Example	Example	Example

Case 2: Download and install stub installer binary 1.49.x with Admin rights_PASSED

• Uninstall 1.49.x from the control panel if it's installed
• Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
• Install 1.49.x stub installer BraveBrowserBetaSetup.exe and ensured that brave is installed successfully and the latest public released beta version is fetched from the Omaha server as expected

Case 3: Download and install standalone silent installer binary 1.49.x_PASSED

• Uninstall 1.49.x from the control panel if it's installed
• Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
• Install 1.49.x standalone silent installer BraveBrowserStandaloneSilentBetaSetup.exe and ensured that brave is installed in silent mode (Installer modal is NOT shown on the UI) and ensured that correct version details are shown brave://settings/help

2. Verify installers and auto-updater works on upgrade profile

Case 1:Verify the Omaha updater version in an upgraded profile (Install 1.48.128 ->upgrade to 1.49.x)_PASSED

Steps :

1. Follow the pre-requisites steps from case 1 to uninstall the Omaha
2. Install the BraveBrowserStandaloneBetaSetup.exe build version 1.48.128 (build before the Omaha updater change 1.3.361.137)
3. Confirmed build is installed successfully and version details are shown correctly in brave://settings/help
4. Confirmed that the old Omaha updater 1.3.361.135 is shown in the registry as expected
5. Confirmed old Omaha updater version 1.3.361.135 is shown in C:\Program Files (x86)\BraveSoftware\Update
6. Go to brave://settings/help and wait for the update click on Relaunch and ensure brave is updated to the latest public beta version 1.49.x

1.48.128 update to ----> 1.49.106

Example	Example	Example	Example

Though the build gets updated from 1.48.128 to 1.49.106, the Omaha updater is still showing up the older version 1.3.361.135, this is because the new updater is not yet uploaded to the production update server/not yet live, the new updater is uploaded to the staging update server hence "Background updates" run is required, the steps are mentioned below.

1. Configure your machine to pull updates from staging by setting the registry string value Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\UpdateDev\url to https://updates.brave.com/service/update2. You need to be connected to VPN to be able to access the staging update server. (To test, you can open https://updates.brave.com. If you get a 404 error, then you have access.)

2. Remove LastChecked from the Update via Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update

3. Run BraveSoftwareUpdateTaskMachineUA from the Windows Task Scheduler. Refresh with F5 until the task has ended

Once the Task Scheduler runs successfully, the Omaha updater version is updated to 1.3.361.137 in both C:\Program Files (x86)\BraveSoftware\Update and Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update

Example	Example

Case 2: Install standalone installer 1.48.x and upgrade the profile to 1.49.x_PASSED

• Uninstall 1.49.x from the control panel if it's installed
• Install standalone beta installer 1.48.128
• Go to brave://settings/help and wait for the update and click on Relaunch (Please note: remove URL parameter in REGEDIT which is set in case 1 above, otherwise you will not see the Relaunch button in 1.48.128 )
• Confirmed that brave is upgraded to 1.49.x public released version

Example	Example

Case 3: Install standalone installer 1.48.x and upgrade the profile to 1.49.x test channel_PASSED

• Uninstall 1.49.x from the control panel if it's installed
• Install 1.48.128 standalone beta installer
• Confirmed brave 1.48.128 installed successfully
• Install the test channel BraveBrowserBetaSetup-64-be-test
• Confirmed that brave is upgraded to 1.49.x test/internal channel

Example	Example

Case 4: Install standalone silent installer 1.48.x and upgrade the profile to 1.49.x_PASSED

• Uninstall 1.49.x from the control panel if it's installed
• Install 1.48.x standalone silent beta installer
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed that brave is upgraded to 1.49.x public released version

Example	Example

3. Verify installers and auto-updater work when the user declines the Admin rights in UAC

[Note: when brave is installed for the current user (without admin rights) the Brave-Browser-Beta folder gets created under the registry path Computer\HKEY_CURRENT_USER\SOFTWARE\BraveSoftware\ and Omaha new updater version is shown as expected]

Case 1: Verify standalone installer can be installed without admin rights and updater works_PASSED

• Install the 1.49.97 beta standalone installer
• Decline the Admin rights in UAC while installing the setup
• Confirmed 1.49.97 the beta standalone installer is installed successfully
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed that the brave is upgraded to 1.49.100 beta public released version

Example	Example	Omaha 1.3.361.137

Case 2: Verify stub installer can be installed without admin rights_PASSED

• Install the beta stub installer
• Decline the Admin rights in UAC while installing the setup
• Confirmed 1.49.100 public released beta version is installed
  

4. Verify that re-install same installer version works

Case 1: Verify standalone installer can be installed twice and update works_PASSED

• Install the 1.49.97 standalone installer twice
• Ensured two brave windows are opened with the same version
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed that brave is updated to 1.49.100 public released version

Example	Example

Case 2: Verify stub installer can be installed twice_PASSED

• Install beta stub installer twice
• Ensured two brave windows are opened with the same version
• Go to brave://settings/help and confirmed that the 1.49.100 public released beta version is shown

Case 3: Verify standalone silent installer can be installed twice and update works_PASSED

• Install 1.49.x standalone silent installer twice
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed that brave is updated to 1.49.x public released version

5. Install quite older installers and check update works correctly

Case 1: Install 1.46.x and ensure upgrade works_PASSED

• Install 1.46.93.x beta build
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed 1.49.x public released version is installed

1.46.x	1.49.x

Case 2: Install 1.42.x and ensure upgrade works_PASSED

• Install 1.42.64 beta build
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed 1.49.x public released version is installed

1.42.x	1.49.x

Case 3: Install 1.40.x and ensure upgrade works_PASSED

• Install 1.40.86 beta build
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed 1.49.x public released version is installed

1.40.x	1.49.x

Case 4: Install 1.30.x and ensure upgrade works_PASSED

• Install 1.30.x beta build
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed 1.49.x public released version is installed

1.30.x	1.49.x

Case 5: Install 1.26.x and ensure upgrade works_PASSED

• Install 1.26.x beta build
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed 1.49.x public released version is installed

1.26.x	1.49.x

6. Verify that install brave works when the Internet is disconnected

Case 1: Verify standalone installer can be installed when the network is disconnected_PASSED

• Install 1.49.x standalone installer
• Confirmed standalone installer is installed successfully and version details are shown correctly
• Go to brave://settings/help and ensured the update is NOT shown which is expected as to pull the Omaha version network needs to be connected

Case 2: Verify standalone silent installer can be installed when the network is disconnected_PASSED

• Install 1.49.x standalone silent installer
• Confirmed standalone silent installer is installed successfully and version details are shown correctly
• Go to brave://settings/help and ensured the update is NOT shown which is expected as to pull the Omaha version network needs to be connected

Case 3: Verify stub installer can't be installed when the network is disconnected_PASSED

• Try installing the stub installer
• Unable to install the installer which is expected as to pull the Omaha version network needs to be connected

7. Verify installing a new binary by older binary from different installers (e.g one is standalone and the other is stub/silent)

Case 1: Install standalone installer 1.48.x and upgrade it by 1.49.x stub installer_PASSED

• Clean profile 1.48.x standalone installer BraveBrowserStandaloneSetup.exe
• Install the standalone installer and confirmed 1.48.x is installed successfully
• Upgrade the profile by 1.49.x stub installer BraveBrowserBetaSetup.exe
• Confirmed that the 1.49.x public releases version is installed successfully

Case 2: Install standalone silent installer 1.48.x and upgrade it by 1.49.x stub installer(decline Admin rights)_PASSED

• Clean profile 1.48.x standalone installer BraveBrowserStandaloneSilentBetaSetup.exe
• Install the standalone silent installer and confirmed 1.48.x is installed successfully
• Upgrade the profile by 1.49.x stub installer BraveBrowserBetaSetup.exe while installing decline the Admin rights
• Go to brave://settings/help and click on Relaunch
• Confirmed that the 1.49.x public releases version is installed successfully

Example	Example

Case 3: Install standalone silent installer 1.48.x and then autoupgrade_PASSED

• Clean profile 1.48.x standalone silent installer BraveBrowserStandaloneSilentBetaSetup.exe
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed that the 1.49.x public release version is installed successfully

Case 4: Install standalone installer 1.48.x and then autoupgrade_PASSED

• Clean profile 1.48.x standalone installer BraveBrowserStandaloneBetaSetup.exe
• Go to brave://settings/help and wait for the update and click on Relaunch
• Confirmed that the 1.49.x public releases version is installed successfully