Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nightly MacOS 1.49.69 browser crashed sometimes #28134

Closed
spylogsster opened this issue Jan 30, 2023 · 1 comment · Fixed by brave/brave-core#16916
Closed

nightly MacOS 1.49.69 browser crashed sometimes #28134

spylogsster opened this issue Jan 30, 2023 · 1 comment · Fixed by brave/brave-core#16916
Assignees
Labels
crash/webview Only tab webview crash. Browser doesn't crash OS/Desktop OS/macOS priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@spylogsster
Copy link

spylogsster commented Jan 30, 2023

Crashes from https://bravesoftware.slack.com/archives/C01826CM3J9/p1675084530072309

[ 00 ] -[BraveAppController shouldShowCleanLinkItem] ( raw_ptr.h:1544 )
[ 01 ] -[BraveAppController shouldShowCleanLinkItem] ( brave_app_controller_mac.mm:40 )
[ 02 ] -[BraveAppController menuNeedsUpdate:] ( brave_app_controller_mac.mm:61 )

Steps

  • opened youtube.com
  • then i closed the window (so Brave is running but has no open windows)
  • select Edit menu item in the top mac menu
@spylogsster spylogsster self-assigned this Jan 30, 2023
@spylogsster spylogsster added this to the 1.49.x - Nightly milestone Jan 30, 2023
@rebron rebron added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Jan 30, 2023
@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/Test-Plan-Specified labels Feb 7, 2023
@stephendonner
Copy link

stephendonner commented Feb 8, 2023

Verification PASSED using

Brave 1.49.89 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

Confirmed crash using 1.49.75:

Steps:

  1. installed
  2. launched Brave
  3. loaded a few YouTube videos
  4. created a temporary Brave Wallet
  5. opened it by clicking on the Brave Wallet icon in the toolbar
  6. returned to a playing YouTube video: https://www.youtube.com/watch?v=2iMBQ-bXQIE
  7. crashed <-------
example example
Screen Shot 2023-02-07 at 3 47 58 PM Screen Shot 2023-02-07 at 3 48 18 PM

Confirmed fix using 1.49.89:

Same steps as above, without the crash (confirmed The General Lee flies through the air):

example example example
Screen Shot 2023-02-07 at 4 07 12 PM Screen Shot 2023-02-07 at 4 07 22 PM Screen Shot 2023-02-07 at 4 07 44 PM

@stephendonner stephendonner added QA Pass-macOS crash/webview Only tab webview crash. Browser doesn't crash and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash/webview Only tab webview crash. Browser doesn't crash OS/Desktop OS/macOS priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants