Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable full screen farbling test #28155

Closed
arthuredelstein opened this issue Jan 31, 2023 · 1 comment · Fixed by brave/brave-core#17277
Closed

Re-enable full screen farbling test #28155

arthuredelstein opened this issue Jan 31, 2023 · 1 comment · Fixed by brave/brave-core#17277
Assignees
@arthuredelstein
Labels
OS/Desktop QA/No release-notes/exclude
Milestone
1.49.x - Release

Comments

@arthuredelstein
Copy link

We partially disabled screen farbling popup test here: #28141

Before rolling out the screen farbling protection, we need to re-enable these tests with a fix so that there are no intermittent failures.
@arthuredelstein arthuredelstein self-assigned this Jan 31, 2023
@arthuredelstein arthuredelstein mentioned this issue Jan 31, 2023
Closed
This was referenced Feb 13, 2023
Merged
Merged
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 22, 2023
This was referenced Feb 24, 2023
Merged
Merged
@kjozwiak kjozwiak added QA/No and removed QA/Yes labels Feb 27, 2023
@kjozwiak kjozwiak modified the milestones: 1.50.x - Nightly, 1.48.x - Release #6 Feb 27, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Mar 8, 2023

Even though the above was merged into the 1.48.x branch, moving this issue into the 1.49.x milestone as we didn't have another 1.48.x release. It was uplifted into 1.49.x & 1.48.x via brave/brave-core#17351 & brave/brave-core#17352. We'll be closing/removing the 1.49.x - Release #6 milestone.

@kjozwiak kjozwiak modified the milestones: 1.48.x - Release #6, 1.49.x - Release Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthuredelstein arthuredelstein

Labels
OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

fix re-enable full FarbleScreenPopupPosition test brave/brave-core
3 participants
@arthuredelstein @kjozwiak @brave-builds