-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect vpn service is not launched in runtime and fallback to DoH #28195
Milestone
Comments
25 tasks
@spylogsster @bsclifton is this Windows only? |
yes, added label |
Verification
|
Brave | 1.50.99 Chromium: 111.0.5563.64 (Official Build) beta (64-bit) |
---|---|
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995} |
OS | Windows 11 Version 21H2 (Build 22000.1696) |
Steps:
- installed
1.50.99
- launched Brave
- restarted (to pick up Griffin changes and enable
VPN
button) - loaded
account.brave.com
- logged in using my
stephen-prod@mailinator.com
account - clicked on
Refresh Brave VPN
button to obtain new credentials - clicked on the
VPN
button in the browser toolbar - toggled from
Disconnected
toConnected
- confirmed I saw the modal dialog about Windows'
Smart Multi-Homed Name Resolution
and our Brave-helper-service workaround - pressed
ctrl
+alt
+del
to openTask Manager
- context-clicked on the
Name
column and checkedCommand line
- looked at the list of
Apps
andBackground processes
- confirmed I saw no
Brave VPN Helper
service (brave_vpn_helper.exe
in the background-processes list - loaded
https://www.browserleaks.com/dns
- compared results to those using the helper service
- opened
brave://settings/security
- compared fall-back settings to those using the helper service
Confirmed the following:
- While connected -- and without the helper service active -- we fall-back to DNS-over-HTTPS support, via Cloudflare
- The above
Use secure DNS
settings islocked by BraveVPN while it is connected
- We don't leak the user's ISP DNS servers
- While disconnected, defaults for
Use secure DNS
/With your current service provider
are used
Brave VPN
, Connected
Helper-service modal dialog | brave://settings/privacy |
---|---|
![]() |
![]() |
Brave VPN
, Disconnected
browserleaks.com/dns | brave://settings/privacy |
---|---|
![]() |
![]() |
Windows 11 | Windows 10 |
---|---|
![]() |
![]() |
Windows 11 | Windows 10 |
---|---|
![]() |
![]() |
Leaving |
Verification PASSED on
|
Helper-service modal dialog | brave://settings/privacy |
---|---|
![]() |
![]() |
Brave VPN
, Disconnected
Confirmed the following:
- While disconnected, defaults for
Use secure DNS
/With your current service provider
are used
browserleaks.com/dns | brave://settings/privacy |
---|---|
![]() |
![]() |
Verified the issue on
|
This has been verified on both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test plan
See brave/brave-core#17013
Description
If brave vpn helper service was not launched by some reasons we have to detect it in runtime and fallback to DoH to protect users from DNS leaks
The text was updated successfully, but these errors were encountered: