Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BalanceScanner contracts for ETH asset discovery #28203

Closed
nvonpentz opened this issue Feb 1, 2023 · 2 comments · Fixed by brave/brave-core#17049
Closed

Use BalanceScanner contracts for ETH asset discovery #28203

nvonpentz opened this issue Feb 1, 2023 · 2 comments · Fixed by brave/brave-core#17049
Assignees
@nvonpentz
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.50.x - Release

Comments

@nvonpentz
Copy link
Member

nvonpentz commented Feb 1, 2023 •
edited
Loading

Depends on #28204.
@nvonpentz nvonpentz added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet/core labels Feb 1, 2023
@nvonpentz nvonpentz self-assigned this Feb 1, 2023
@nvonpentz nvonpentz added this to Web3 Feb 1, 2023
@nvonpentz nvonpentz moved this to In Progress in Web3 Feb 1, 2023
This was referenced Feb 1, 2023
Closed
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Feb 17, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 17, 2023
@yrliou yrliou mentioned this issue Feb 23, 2023
Open
15 tasks
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.50.94 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#17049
  • Verified restoring an account with token balance via seed phrase, auto-populates all the tokens with balance
  • Verified sending a token to an account which doesn't have the balance, lists the token and shows the balance

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.50.93 x64 build

  • Verified steps from brave/brave-core#17049
  • Verified restoring an account with token balance via seed phrase, auto-populates all the tokens with balance
  • Verified sending a token to an account which doesn't have the balance, lists the token and shows the balance

@LaurenWags LaurenWags mentioned this issue Apr 4, 2023
Closed
@kjozwiak kjozwiak mentioned this issue Apr 6, 2023
Closed
@kjozwiak kjozwiak mentioned this issue May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvonpentz nvonpentz

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

Use BalanceScanner contracts for ETH asset discovery brave/brave-core
3 participants
@nvonpentz @srirambv @brave-builds