Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label for transactions with 'Signed' status not shown #28205

Closed
josheleonard opened this issue Feb 1, 2023 · 2 comments · Fixed by brave/brave-core#16956
Closed

Label for transactions with 'Signed' status not shown #28205

josheleonard opened this issue Feb 1, 2023 · 2 comments · Fixed by brave/brave-core#16956
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include

Comments

@josheleonard
Copy link

Description

Transactions with a status of BraveWallet.TransactionStatus.Signed are not displaying a status label
Screen Shot 2023-01-31 at 22 44 30
Screen Shot 2023-01-31 at 22 48 16

Steps to Reproduce

  1. Setup wallet
  2. Setup https://github.com/bbondy/eth-manual-tests
  3. Change to any test network and visit http://localhost:8081/request.html
  4. Click ethereum.enable and grant permission
  5. Fill to address next to eth_signTransaction and click it
  6. Check transactions on brave://wallet/crypto/portfolio/ETH

Actual result:

there should be a transaction with a missing status label

Expected result:

there should be a "Signed" transaction

Reproduces how often:

Easy

Brave version (brave://version info)

1.49.78

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@kjozwiak
Copy link
Member

kjozwiak commented Feb 4, 2023

The above requires 1.48.156 or higher for 1.48.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Feb 7, 2023

Verification passed on

Brave 1.48.157 Chromium: 110.0.5481.77 (Official Build) (64-bit)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS Windows 11 Version 22H2 (Build 22621.1105)
  • Verified steps from brave/brave-core#16956
  • Verified Signed transaction status is shown under activity
  • Verified both Normal flow and Nonce flow work as expected
  • Encountered #28333
28205.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants