Crash on wallet in PortfolioFragment

[SergeyZhukovsky]

I found that crash in GPS on 1.49.81:

Exception java.lang.NullPointerException:
  at org.chromium.chrome.browser.crypto_wallet.fragments.PortfolioFragment.updatePortfolioGetPendingTx (PortfolioFragment.java:482)
  at org.chromium.chrome.browser.crypto_wallet.fragments.PortfolioFragment.lambda$setUpObservers$3 (PortfolioFragment.java:211)
  at org.chromium.chrome.browser.crypto_wallet.fragments.PortfolioFragment$$InternalSyntheticLambda$3$376baa504b705602c0c3178a9ebced4b462570a1e063c5bb6b1e1550caf6c946$0.onChanged$bridge (PortfolioFragment.java:303)
  at androidx.lifecycle.LiveData.considerNotify (LiveData.java:133)
  at androidx.lifecycle.MutableLiveData.considerNotify (MutableLiveData.java:30)
  at androidx.lifecycle.LiveData.dispatchingValue (LiveData.java:146)
  at androidx.lifecycle.MutableLiveData.dispatchingValue (MutableLiveData.java:16)
  at androidx.lifecycle.LiveData$ObserverWrapper.activeStateChanged (LiveData.java:483)
  at androidx.lifecycle.LiveData$LifecycleBoundObserver.onStateChanged (LiveData.java:440)
  at androidx.lifecycle.LifecycleRegistry$ObserverWithState.dispatchEvent (LifecycleRegistry.kt:314)
  at androidx.lifecycle.LifecycleRegistry.forwardPass (LifecycleRegistry.kt:251)
  at androidx.lifecycle.LifecycleRegistry.sync (LifecycleRegistry.kt:287)
  at androidx.lifecycle.LifecycleRegistry.moveToState (LifecycleRegistry.kt:136)
  at androidx.lifecycle.LifecycleRegistry.handleLifecycleEvent (LifecycleRegistry.kt:119)
  at androidx.fragment.app.FragmentViewLifecycleOwner.handleLifecycleEvent (FragmentViewLifecycleOwner.java:100)
  at androidx.fragment.app.Fragment.performStart (Fragment.java:3184)
  at androidx.fragment.app.FragmentStateManager.start (FragmentStateManager.java:625)
  at androidx.fragment.app.FragmentStateManager.moveToExpectedState (FragmentStateManager.java:290)
  at androidx.fragment.app.FragmentStore.moveToExpectedState (FragmentStore.java:114)
  at androidx.fragment.app.FragmentManager.moveToState (FragmentManager.java:1433)
  at androidx.fragment.app.FragmentManagerImpl.moveToState (FragmentManagerImpl.java:58)
  at androidx.fragment.app.FragmentManager.dispatchStateChange (FragmentManager.java:2980)
  at androidx.fragment.app.FragmentManagerImpl.dispatchStateChange (FragmentManagerImpl.java:34)
  at androidx.fragment.app.FragmentManager.dispatchStart (FragmentManager.java:2905)
  at androidx.fragment.app.FragmentController.dispatchStart (FragmentController.java:274)
  at androidx.fragment.app.FragmentActivity.onStart (FragmentActivity.java:359)
  at androidx.appcompat.app.AppCompatActivity.onStart (AppCompatActivity.java:251)
  at org.chromium.chrome.browser.init.AsyncInitializationActivity.onStart (AsyncInitializationActivity.java:490)
  at android.app.Instrumentation.callActivityOnStart (Instrumentation.java:1529)
  at android.app.Activity.performStart (Activity.java:8416)
  at android.app.ActivityThread.handleStartActivity (ActivityThread.java:3894)
  at android.app.servertransaction.TransactionExecutor.performLifecycleSequence (TransactionExecutor.java:221)
  at android.app.servertransaction.TransactionExecutor.cycleToPath (TransactionExecutor.java:201)
  at android.app.servertransaction.TransactionExecutor.executeLifecycleState (TransactionExecutor.java:173)
  at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:97)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2466)
  at android.os.Handler.dispatchMessage (Handler.java:106)
  at android.os.Looper.loopOnce (Looper.java:240)
  at android.os.Looper.loop (Looper.java:351)
  at android.app.ActivityThread.main (ActivityThread.java:8355)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:584)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1013)

[Pavneet-Sing]

It seems like the conventional KeyringService method object is returning null but the domain model implementation seems to be working fine. Replacing the implementation with domain model though not able to reproduce the crash.
This seems like it could also happen on other variants so will uplift.

[kjozwiak]

Going to label this as QA/No after speaking with @srirambv. This will get verified by default when @srirambv is running through 1.48.x verifications which usually always requires the creation of new wallets/connecting to different networks etc..