In country selection list for declared geo, place OS region/locale country at top of list

[Miyayes]

Description

For better UX, we should place the user's device/OS region/locale at the top of the country dropdown list for ease.

[LaurenWags]

Removed QA Pass-macOS and added QA/Blocked. Per discussion with @szilardszaloki blocking this issue until we get an uplift of brave/brave-core#18025 to 1.51.x.

[LaurenWags]

Removing QA/Blocked since #29609 has been uplifted to 1.51.x, so this can be retested.

@brave/qa-team please use updated test plan on brave/brave-core#17427. My previous testing comment has been hidden so as to avoid confusion.

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.51.95 Chromium: 112.0.5615.121 (Official Build) beta (64-bit)
-- | --
Revision | 39cc4e45904ae9f1741c4fbaa866e629c96f2268-refs/branch-heads/5615_51@{#8}
OS | Windows 10 Version 21H2 (Build 19044.2846)

Clean profile

UK region_PASSED

1. Set OS locale to United Kingdom
2. Install brave 1.51.95
3. Tap on the BAT icon and click on the Start Brave Rewards
4. Click on the country dropdown
5. Confirmed that the country which is set in the OS settings will be in the first place in the country dropdown after installing Brave.

OS region	OS region at the top of the list

IN region_PASSED

1. Set OS locale to India
2. Install brave 1.51.95
3. Tap on the BAT icon and click on the Start Brave Rewards
4. Click on the country dropdown
5. Confirmed that the country which is set in the OS settings will be in the first place in the country dropdown after installing Brave.

OS region	OS region at the top of the list

Switzerland region_PASSED

1. Set OS locale to Switzerland
2. Install brave 1.51.95
3. Tap on the BAT icon and click on the Start Brave Rewards
4. Click on the country dropdown
5. Confirmed that the country which is set in the OS settings will be in the first place in the country dropdown after installing Brave.

OS region	OS region at the top of the list

Upgrade profile

Case 1: OS region India>Install 1.50.121>select UK>connect uphold>Reset rewards>install beta 1.51.x>Confirm country IN in first place_PASSED

1. Set OS locale to India
2. Clean install RC 1.50.121 enable rewards
3. Select UK from the country dropdown and connect uphold custodian
4. Confirm that custodian is connected
5. Reset rewards
6. Close the browser
7. Rename the profile to beta
8. Install 1.51.95 beta build
9. Tap on the BAT icon and click on country dropdown
10. Confirmed that the country India which is set in the OS settings will be in the first place in the country dropdown after installing Beta.

step 1	step 3	step 3	step 4	step 9	step 10

Case 2: OS region India>Install 1.50.86>select UK>connect uphold>auto update to 1.51.x via brave://settings/help>Confirm country IN in first place_PASSED

1. Set OS locale to India
2. Install the beta build 1.50.86
3. Select UK from the country dropdown and connect uphold custodian
4. Confirm that custodian is connected
5. Open brave://settings/help
6. Wait for the auto upgrade to 1.51.x, click on Relaunch once the update is available
7. Tap on the BAT and confirm that uphold is in connected state and country dropdown is not shown
8. Reset rewards
9. Tap on the BAT icon and click on the country dropdown and ensure that the country India which is set in the OS settings will be in the first place as expected

step 1	step 3	step 4	step 6	step 7	step 8	step 9

Case 3: OS region UK>Install 1.50.86>select UK>connect uphold>change OS to US>upgrade to 1.51.x>confirm uphold is still connected>reset rewards>Confirm country UK in first place_PASSED

1. Set OS locale to United Kingdom
2. Install the beta build 1.50.86
3. Select United Kingdom from the country dropdown and connect uphold custodian
4. Confirm that custodian is connected
5. Close the browser
6. Change the OS region to United States
7. Relaunch browser
8. Upgrade the profile to 1.51.97 beta via brave://settings/help
9. Confirm that uphold is still in connected state
10. Reset rewards
11. Tap on the BAT icon and click on the country dropdown and ensure that the country United Kingdom which is set in the OS settings will be in the first place as expected

step 1 | step 3 | step 4 | step 6 | step 8 | step 10 | step 11
---------|-----------|------------|---------
| | | | | |

• Additional scenarios are tested under Full country list displayed for Rewards when only Japan is expected in certain case - Follow up to 28887 and 28321 #29609 (comment)

[LaurenWags]

Verified with

Brave | 1.51.107 Chromium: 113.0.5672.63 (Official Build) (x86_64)
-- | --
Revision | 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS | macOS Version 13.3.1 (Build 22E261)

Note, additional related testing done under #29609 (comment).

Clean profile

US region - PASSED

1. Set OS locale to United States
2. Install brave 1.51.x
3. Tap on the BAT icon and click on the Start Brave Rewards
4. Click on the country dropdown
5. Confirmed that the country which is set in the OS settings will be in the first place in the country dropdown after installing Brave.

OS region	OS region at the top of the list

Canada region - PASSED

1. Set OS locale to Canada
2. Install brave 1.51.x
3. Tap on the BAT icon and click on the Start Brave Rewards
4. Click on the country dropdown
5. Confirmed that the country which is set in the OS settings will be in the first place in the country dropdown after installing Brave.

OS region	OS region at the top of the list

Japan region - PASSED

1. Set OS locale to Japan
2. Install brave 1.51.x
3. Tap on the BAT icon and click on the Start Brave Rewards
4. Click on the country dropdown
5. Confirmed that the country which is set in the OS settings will be in the first place in the country dropdown after installing Brave.

OS region	OS region at the top of the list

Upgrade profile

Case 1: OS region US>Install 1.50.121>select Canada>connect uphold>Reset rewards>update to 1.51.x>Confirm country US in first place - PASSED

1. Set OS locale to US
2. Clean install 1.50.121 enable rewards
3. Select Canada from the country dropdown and connect uphold custodian
4. Confirm that custodian is connected
5. Reset rewards
6. Close the browser
7. Relaunch with test channel update parameter and relaunch when update is complete
8. Tap on the BAT icon and click on country dropdown
9. Confirmed that the country US which is set in the OS settings will be in the first place in the country dropdown after installing 1.51.x.

Step 1	Step 3	Step 3	Step 5	Step 9

Case 2: OS region Canada>Install 1.50.121>select US>connect gemini>update to 1.51.x via brave://settings/help>Confirm country Canada in first place - PASSED

1. Set OS locale to Canada
2. Install 1.50.121
3. Select US from the country dropdown and connect gemini custodian
4. Confirm that custodian is connected
5. Close/relaunch with test channel command line parameters and brave://settings/help to update
6. Wait for the auto upgrade to 1.51.x, and relaunch (via terminal) once the update is available
7. Tap on the BAT and confirm that uphold is in connected state and country dropdown is not shown
8. Reset rewards
9. Tap on the BAT icon and click on the country dropdown and ensure that the country Canada which is set in the OS settings will be in the first place as expected

step 1	step 3	step 4	step 6	step 7	step 8	step 9

Case 3: OS region US>Install 1.50.121>select US>connect uphold>change OS to Canada>upgrade to 1.51.x>confirm uphold is still connected>reset rewards>Confirm country US in first place - PASSED

1. Set OS locale to United States
2. Install 1.50.121
3. Select United States from the country dropdown and connect uphold custodian
4. Confirm that custodian is connected
5. Close the browser
6. Change the OS region to Canada
7. Relaunch browser
8. Upgrade the profile to 1.51.x via brave://settings/help while launched w/ test channel update command line
9. Confirm that uphold is still in connected state
10. Reset rewards
11. Tap on the BAT icon and click on the country dropdown and ensure that the country United States which was the country at install OS settings will be in the first place as expected

Step 1	Step 3	Step 4	Step 6	Step 8	Step 9	Step 10	Step 11

[btlechowski]

Verification passed on

Brave	1.51.105 Chromium: 112.0.5615.165 (Official Build) beta (64-bit)
Revision	c262f36e6b1d711ee42d4fbe1343b49960593f18-refs/branch-heads/5615@{#1297}
OS	Ubuntu 18.04 LTS

Clean profile - US - PASSED

1. Set OS locale to United States
2. Install brave 1.51.x
3. Tap on the BAT icon and click on the Start Brave Rewards
4. Click on the country dropdown
5. Confirmed that the country which is set in the OS settings will be in the first place in the country dropdown after installing Brave.

Clean Profile - PL - PASSED

1. Set OS locale to Poland
2. Install brave 1.51.x
3. Tap on the BAT icon and click on the Start Brave Rewards
4. Click on the country dropdown
5. Confirmed that the country which is set in the OS settings will be in the first place in the country dropdown after installing Brave.

Upgrade - US - PASSED

1. Set OS locale to US
2. Clean install RC 1.50.121 enable rewards
3. Select UK from the country dropdown and connect uphold custodian
4. Confirm that custodian is connected
5. Reset rewards
6. Close the browser
7. Rename the profile to beta
8. Install 1.51.x beta build
9. Tap on the BAT icon and click on country dropdown
10. Confirmed that the country US which is set in the OS settings will be in the first place in the country dropdown after installing Beta.

Upgrade - PL - PASSED

1. Set OS locale to Poland
2. Install the beta build 1.50.86
3. Select UK from the country dropdown and connect uphold custodian
4. Confirm that custodian is connected
5. Open brave://settings/help
6. upgrade to 1.51.x
7. Tap on the BAT and confirm that uphold is in connected state and country dropdown is not shown
8. Reset rewards
9. Tap on the BAT icon and click on the country dropdown and ensure that the country Poland which is set in the OS settings will be in the first place as expected