Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eth_signTransaction and eth_sendRawTransaction #28363

Closed
srirambv opened this issue Feb 8, 2023 · 1 comment · Fixed by brave/brave-core#17842
Closed

Support eth_signTransaction and eth_sendRawTransaction #28363

srirambv opened this issue Feb 8, 2023 · 1 comment · Fixed by brave/brave-core#17842
Assignees
Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 8, 2023

Android version of #23582.

Note: Currently on Android when trying to submit an eth_signTransaction it shows successful output in console but when trying to do a eth_sendRawTransaction it errors out {code: -32602, message: 'transaction could not be decoded: unsupported transaction type'}

cc: @yrliou @darkdh @bbondy

@srirambv srirambv added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality feature/web3/wallet/dapps labels Feb 8, 2023
@srirambv srirambv added this to Web3 Feb 8, 2023
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Feb 10, 2023
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 10, 2023
@SergeyZhukovsky SergeyZhukovsky moved this from Backlog to In Progress in Web3 Mar 2, 2023
@wchen342
Copy link

It seems the transaction could not be decoded message is because you were inputting the Tx hash into the raw tx input box, but you are supposed to copy the full string from console (which is not easy to do with Android remote DevTools, I did it with $x("//input[@id='request-send-raw-tx']")[0].value = "{The Long String}" in DevTools console on PC). When I tried with the complete string eth_sendRawTransaction actually worked fine. @srirambv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants