Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show title for custom filter list subscriptions #28416

Closed
antonok-edm opened this issue Feb 9, 2023 · 1 comment · Fixed by brave/brave-core#17125
Closed

Show title for custom filter list subscriptions #28416

antonok-edm opened this issue Feb 9, 2023 · 1 comment · Fixed by brave/brave-core#17125

Comments

@antonok-edm
Copy link
Collaborator

The Title field of custom adblock filter list subscriptions was previously exposed to the browser (#17910), but never shown in the UI. It should be displayed instead of the subscription URL, if it is available.

@antonok-edm antonok-edm self-assigned this Feb 9, 2023
@antonok-edm antonok-edm changed the title Show title for custom filter list subscriptionis Show title for custom filter list subscriptions Feb 9, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 13, 2023
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 13, 2023
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.50.90 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | Windows 11 Version 22H2 (Build 22621.1265)

New profile:

  1. Install 1.50.90
  2. launch Brave
  3. open a new-tab
  4. visited brave://settings/shields/filters
  5. added https://filters.adtidy.org/extension/chromium/filters/17.txt to the Add custom filter lists section
  6. confirmed that the title of the first column in the table displayed as List title
  7. confirmed that the entry under List title is AdGuard URL Tracking filter
  8. added https://raw.githubusercontent.com/AdguardTeam/AdguardFilters/master/TrackParamFilter/sections/general_url.txt as second custom filter list
  9. confirmed that the title is just the URL of the list (truncated as necessary to fit on-screen)
  10. confirmed when hovered over each of the titles, mouseover text shows the full original URLs used to subscribe to each
step 5 step 6-7 step 9 step 10a step 10b
image image image image image

Upgrade:

  1. Install 1.49.120
  2. launch Brave
  3. open a new-tab
  4. visited brave://settings/shields/filters
  5. added https://filters.adtidy.org/extension/chromium/filters/17.txt to the Add custom filter lists section
  6. verified that the title of the first column in the table is displayed as List URL and full URL is displayed
  7. added https://raw.githubusercontent.com/AdguardTeam/AdguardFilters/master/TrackParamFilter/sections/general_url.txt as second custom filter list
  8. close the browser
  9. install 1.50.90
  10. rename the Brave-Browser profile as Brave-Browser-Beta
  11. launch Brave
  12. got to brave://settings/shields/filters
  • Confirmed that the title of the first column in the table displayed as List title instead of List URL
  • Confirmed the first entry under List title in the Custom lists table is AdGuard URL Tracking filter instead of full URL
  • Confirmed the second entry in the Custom lists table is displayed as URL and is truncated
  • Confirmed when hovered over each of the titles, mouseover text shows the full original URLs used to subscribe to each
step 1 step 4-7 result result
image image image image

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants