Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unplayable Videos on sportsnet.ca #2843

Closed
jonathansampson opened this issue Jan 7, 2019 · 4 comments · Fixed by brave/brave-core#1429
Closed

Unplayable Videos on sportsnet.ca #2843

jonathansampson opened this issue Jan 7, 2019 · 4 comments · Fixed by brave/brave-core#1429
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website.

Comments

@jonathansampson
Copy link
Contributor

jonathansampson commented Jan 7, 2019

Description

Videos are not playable with default shield settings on sportsnet.ca.

Steps to Reproduce

  1. Navigate to https://www.sportsnet.ca/hockey/nhl/talbot-robs-gibbons-doorstep-point-blank-save/
  2. Attempt to play the video

Actual result:

Video will not play.

Expected result:

Video plays.

Reproduces how often:

Always

Brave version (brave://version info)

0.58.18

Reproducible on current release:

Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Is the issue reproducible on the latest version of Chrome? No

Additional Information

In order to play the video content, the user must Allow Ads and Trackers and Allow all Cookies. This issue was originally reported on Twitter:

image

@jonathansampson jonathansampson added webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website. labels Jan 7, 2019
@bbondy bbondy added this to the 1.x Backlog milestone Jan 13, 2019
@mrzealot
Copy link

Allowing all cookies wasn't necessary for me on 0.58.21, only the "Ads and trackers" switch. It also runs into autoplay, which won't be allowed because of the ad blocker catching the video...

@bbondy
Copy link
Member

bbondy commented Jan 23, 2019

This is fixed and under review here:
brave-experiments/ad-block#162

If accepted, it'll go onto dev channel which moves to Beta on Jan 29th.
And release channel Feb 19th.

@srirambv
Copy link
Contributor

Marking as 0.60.x as brave/brave-core#1430 is uplifted to 0.60.x

@srirambv srirambv modified the milestones: 1.x Backlog, 0.60.x - Beta Jan 29, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 11, 2019

Verification passed on

Brave 0.60.25 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 10

Verified passed with

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X
  • Verified steps from description

Verification passed on

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants