Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in GPS nightly version related to BraveNotificationWarningDialog #28483

Closed
deeppandya opened this issue Feb 13, 2023 · 1 comment
Closed
Assignees
Labels
closed/duplicate Issue has already been reported crash dev-concern OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude

Comments

@deeppandya
Copy link

There seems to be an issue with checking if rewards is enabled before native is initialize.
Exception java.lang.RuntimeException: at android.app.ActivityThread.performResumeActivity (ActivityThread.java:3672) at android.app.ActivityThread.handleResumeActivity (ActivityThread.java:3712) at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:2949) at android.app.ActivityThread.-wrap11 (ActivityThread.java) at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1630) at android.os.Handler.dispatchMessage (Handler.java:106) at android.os.Looper.loop (Looper.java:164) at android.app.ActivityThread.main (ActivityThread.java:6626) at java.lang.reflect.Method.invoke (Method.java) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:438) at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:811) Caused by java.lang.IllegalStateException: Browser hasn't finished initialization yet! at org.chromium.chrome.browser.profiles.Profile.getLastUsedRegularProfile (Profile.java:54) at org.chromium.chrome.browser.notifications.BraveNotificationWarningDialog.isBraveRewardsEnabled (BraveNotificationWarningDialog.java:143) at org.chromium.chrome.browser.notifications.BraveNotificationWarningDialog.shouldShowRewardWarningDialog (BraveNotificationWarningDialog.java:95) at org.chromium.chrome.browser.notifications.BraveNotificationWarningDialog.shouldShowNotificationWarningDialog (BraveNotificationWarningDialog.java:86) at org.chromium.chrome.browser.app.BraveActivity.checkAndshowNotificationWarningDialog (BraveActivity.java:1339) at org.chromium.chrome.browser.app.BraveActivity.onNewIntent (BraveActivity.java:1721) at org.chromium.chrome.browser.ChromeTabbedActivity.onNewIntent (ChromeTabbedActivity.java:971) at android.app.Activity.performNewIntent (Activity.java:7044) at android.app.Instrumentation.callActivityOnNewIntent (Instrumentation.java:1331) at android.app.Instrumentation.callActivityOnNewIntent (Instrumentation.java:1343) at android.app.ActivityThread.deliverNewIntents (ActivityThread.java:3023) at android.app.ActivityThread.performResumeActivity (ActivityThread.java:3640)

@deeppandya deeppandya added crash dev-concern release-notes/exclude OS/Android Fixes related to Android browser functionality labels Feb 13, 2023
@SergeyZhukovsky SergeyZhukovsky added the closed/duplicate Issue has already been reported label Feb 17, 2023
@SergeyZhukovsky
Copy link
Member

that is fixed in the context of that issue #27810. @deeppandya I wonder what version were you looking at? We fixed that back in 1.47.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported crash dev-concern OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Projects
None yet
Development

No branches or pull requests

3 participants