Create a new crash reporting endpoint

[bbondy]

No description provided.

[bbondy]

We'll just be re-using https://laptop-updates.brave.com/1/crashes for now.
Can this be closed @aekeus or is there anything else to do here?

[aekeus]

Yes, we will need to inspect the platform from the crash and send it to a different queue. cc @KarateCowboy

[emerick]

Sounds like we'll use the endpoint 1/bc-crashes for brave-core.

[aekeus]

Implemented by brave/vault-updater@4cf8e50

[bbondy]

QA notes: Just make sure you can send a crash from about:crashes and that you can search for the ID.

[srirambv]

Linux Crash doesn't list in chrome://crashes. Navigating to chrome://crash shows this error message

[bbondy]

@srirambv pls post an issue for the 1.x backlog for ^

[btlechowski]

Sending crash reports does not work on Win7: #1188

[GeetaSarvadnya]

On windows 10 also, crash reports are not getting generated.

[emerick]

@GeetaSarvadnya I think you need to enable it in chrome://settings/ first. The chrome://crashes/ page says that "Crash reporting is disabled" in that video.

[kjozwiak]

@emerick there's seems to be a bug on all the platforms where the report that was just submitted doesn't appear under chrome://crashes when the tab is restored after a restart. @GeetaSarvadnya is creating a new bug. Reports are being submitted though 👍

Example of the issue that @GeetaSarvadnya is posting:

• visit chrome://crash in a new profile
• open a new tab, visit chrome://crashes and click on Send
• Restart the browser and the restored chrome://crashes window won't display the recent crash
• refresh the same tab, and you'll notice that the crash will appear as submitted as expected

I'm guessing it's either:

• chrome://crashes isn't correctly refreshed when it's the active tab and is restored
• when chrome://crashes is restored, the crash report is still being submitted, hence not appearing

[srirambv]

@emerick without enabling it i can still see crash reports uploaded

Not sure what data is uploaded to crash server with that setting being disabled by default

[emerick]

@srirambv Yes, manual uploads are still allowed even when "crash reporting" is disabled. I think the option is specifically worded as "Automatically send usage statistics and crash reports to Brave", i.e. the "automatically" is the key part there.

[emerick]

@kjozwiak OK, I see. I think you're correct and it's the second option that you list "when chrome://crashes is restored, the crash report is still being submitted, hence not appearing". Probably just down to timing as to whether you will see it that quickly.

[srirambv]

verified its a timing issue between uploading and display. With the automatic setting enabled, crash reports are shown instantly on chrome://crashes and uploaded as well.

[kjozwiak]

@emerick @GeetaSarvadnya created #1299. However, it's not really a "blocker" or a high priority issue. Maybe it will fix itself once your backend performance improves? Either way, these are the two major issues remaining re: crash reports:

• Linux Crash doesn't list in chrome://crashes. Navigating to chrome://crash shows error message #1251 (Reports not working under Linux)
• chrome://crashes not working under Win 7 #1188 (Reports not working under Win 7)

[emerick]

@kjozwiak Is #1188 not the same chrome://settings/ problem?

[kjozwiak]

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave	0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Mac OS X

Verification Passed on

Brave	0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Windows 10

• Based on above discussion issue is verified on WIndows 10 and Mac. Linux issue is being tracked in Linux Crash doesn't list in chrome://crashes. Navigating to chrome://crash shows error message #1251

[kjozwiak]

@kjozwiak Is #1188 not the same chrome://settings/ problem?

Nope, it doesn't work on Win 7 in general. Both manual submission and automatic via Automatically send crash reports to Brave doesn't work. Added more information into #1188.

[emerick]

@kjozwiak OK, I see, thanks for the details! I don't see any reason that Windows 7 in particular would be excluded, but I'll continue to dig around.

[kjozwiak]

Sounds good! Let me know if you need any help testing anything! The Win 7 issue has been around since the early days of b-l. Originally, reporting wasn't working on any platform. Win 7 & Linux where the only ones that weren't fixed. Seemed like the issue has followed us into b-c :(