Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text needs updating on Activity tab #28535

Closed
HEagle18 opened this issue Feb 15, 2023 · 1 comment · Fixed by brave/brave-core#18017
Closed

Text needs updating on Activity tab #28535

HEagle18 opened this issue Feb 15, 2023 · 1 comment · Fixed by brave/brave-core#18017
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include

Comments

@HEagle18
Copy link

HEagle18 commented Feb 15, 2023

Description

We should keep the actions in the same tense. For example, it should be SWAP, RECEIVE, SEND. All actions should be in cap locks too.
Right now, it says 'sent' and 'swap' beside each other
Screenshot 2023-02-15 at 16 24 28

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (info found on brave://version)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@HEagle18 HEagle18 added bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes labels Feb 15, 2023
@HEagle18 HEagle18 added this to Web3 Feb 15, 2023
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Feb 17, 2023
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 17, 2023
@HEagle18 HEagle18 removed their assignment Feb 24, 2023
@HEagle18 HEagle18 changed the title Text needs updating on Transaction tab Text needs updating on Acitivity tab Mar 23, 2023
@josheleonard josheleonard moved this from Backlog to In Progress in Web3 Apr 12, 2023
@josheleonard josheleonard self-assigned this Apr 12, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Apr 17, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 17, 2023
@stephendonner stephendonner changed the title Text needs updating on Acitivity tab Text needs updating on Activity tab May 4, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.52.94 Chromium: 113.0.5672.92 (Official Build) beta (64-bit)
Revision b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS Windows 11 Version 22H2 (Build 22621.1702)
Dark Light
brave_E14QBCoZJb brave_tpgJQLWGye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants