Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with multiple onboarding tabs opening up for Magic Eden #28546

Closed
HEagle18 opened this issue Feb 15, 2023 · 3 comments · Fixed by brave/brave-core#17241
Closed

Fix issue with multiple onboarding tabs opening up for Magic Eden #28546

HEagle18 opened this issue Feb 15, 2023 · 3 comments · Fixed by brave/brave-core#17241

Comments

@HEagle18
Copy link

HEagle18 commented Feb 15, 2023

Description

When we try connect Brave Wallet to Magic Eden on Solana, it just creates multiple tabs endlessly.

Attached is video replicating this issue. Done on 1.48 on desktop.

Screen.Recording.2023-02-15.at.19.16.09.mov

Steps to Reproduce

  1. try connecting Brave wallet to magic eden
  2. on 1.48
  3. with a new browser profile and don't have the wallet already created.

Actual result:

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.50.85 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Linux
  • Verified steps from brave/brave-core#17241
  • Verified only one onboarding tab is loaded when visiting https://magiceden.io and clicking on Connect Wallet
  • Verified if an onboarding tab is already opened via the page, trying again to connect doesn't launch a new one
28546.mp4

Verification passed on

Brave 1.50.85 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#17241
  • Verified only one onboarding tab is loaded when visiting https://magiceden.io and clicking on Connect Wallet
  • Verified if an onboarding tab is already opened via the page, trying again to connect doesn't launch a new one
28546.mp4

Verification passed on

Brave 1.50.85 Chromium: 111.0.5563.64 (Official Build) beta (arm64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#17241
  • Verified only one onboarding tab is loaded when visiting https://magiceden.io and clicking on Connect Wallet
  • Verified if an onboarding tab is already opened via the page, trying again to connect doesn't launch a new one
28546.mov

@kjozwiak
Copy link
Member

The above will require 1.49.132 or higher for 1.49.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.49.132 Chromium: 111.0.5563.147 (Official Build) (64-bit)
Revision 029fd65a4dd711d1078468ed2206999cec86066b-refs/branch-heads/5563@{#1239}
OS Windows 11 Version 22H2 (Build 22621.1413)
  • Verified steps from brave/brave-core#17241
  • Verified only one onboarding tab is loaded when visiting https://magiceden.io and clicking on Connect Wallet
  • Verified if an onboarding tab is already opened via the page, trying again to connect doesn't launch a new one
28546.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants