Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying brave:// URL using keyboard shortcut copies chrome:// scheme #28588

Closed
stephendonner opened this issue Feb 17, 2023 · 8 comments
Closed
Assignees

Comments

@stephendonner
Copy link

Description

Copying brave:// URL using keyboard shortcut copies chrome:// scheme

Steps to Reproduce

  1. install 1.49.100
  2. launch Brave
  3. open brave://settings/appearance
  4. copy the above URL using command + C
  5. paste and note the URL
  6. copy the above URL using the Copy context-menu item
  7. paste and note the URL

Actual result:

command+C = chrome://settings/appearance
Copy context-menu = brave://settings/appearance

Expected result:

In both cases, it should copy brave://settings/appearance

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.49.100 Chromium: 110.0.5481.100 (Official Build) beta (x86_64)
Revision 4be7a36f7cb943af6118e449bbab494b43dcaddd-refs/branch-heads/5481_77@{#14}
OS macOS Version 11.7.4 (Build 20G1120)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

/cc @spylogsster @LaurenWags @rebron @kjozwiak @emerick @mkarolin

@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. branding labels Feb 17, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 17, 2023

Couldn't reproduce the issue in Win 11 x64 (Ctrl + C)

Brave | 1.49.100 Chromium: 110.0.5481.100 (Official Build) beta (64-bit)
-- | --
Revision | 4be7a36f7cb943af6118e449bbab494b43dcaddd-refs/branch-heads/5481_77@{#14}
OS | Windows 11 Version 21H2 (Build 22000.1574)

@LaurenWags
Copy link
Member

Can reproduce with 1.49.100 (C110) on Beta but not a prior release 1.47.186 (C109).

Seems like possibly a C110 regression.

@spylogsster
Copy link

spylogsster commented Feb 21, 2023

Looks like fixed in latest master, cannot reproduce it on 1.50.50 Nightly for macos, but was able to reproduce on 1.50.38,
@stephendonner @LaurenWags @MadhaviSeelam can you pls recheck on your side 1.50.50+ Nightly? thanks

@stephendonner
Copy link
Author

Looks like fixed in latest master, cannot reproduce it on 1.50.50 Nightly for macos, but was able to reproduce on 1.50.38, @stephendonner @LaurenWags @MadhaviSeelam can you pls recheck on your side 1.50.50+ Nightly? thanks

Can confirm it's working again/fixed in

Brave 1.50.53 Chromium: 110.0.5481.104 (Official Build) nightly (x86_64)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS macOS Version 11.7.4 (Build 20G1120)

@spylogsster
Copy link

Closing as not reproducible anymore

@rebron
Copy link
Collaborator

rebron commented Mar 3, 2023

@LaurenWags @stephendonner @MadhaviSeelam Can you recheck this with the release candidate 1.49.117 Chromium: 111.0.5563.50 (Official Build) (arm64)

I'm seeing chrome:// when copying from an internal page.

@LaurenWags
Copy link
Member

LaurenWags commented Mar 3, 2023

@rebron Tried with 1.49.117 and can reproduce, I get chrome:// instead of brave:// example - copied brave://version/ via cmd + C but chrome://version/ was pasted here. Copying brave://version/ via context menu pastes brave://version/ as expected.

However, also tried with 1.49.118 (newer RC) and I am getting brave:// not chrome://.

Example, copied from brave://settings/appearance and pasted in this comment. Pasting in Slack does the same thing. Tried copying via "cmd + C" as well as context menu.

Can you try the latest RC to confirm?

Note - #28542 was uplifted to 1.49.118 and is not in 1.49.117, wonder if that fixed it?

@rebron
Copy link
Collaborator

rebron commented Mar 9, 2023

Closing. Tested in latest RC. Looks good with copy and paste from steps in last comment.

Brave 1.49.120 Chromium: 111.0.5563.64 (Official Build) (arm64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 13.3 (a) (Build 22E7752300f)
JavaScript V8 11.1.277.13
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36

@rebron rebron closed this as completed Mar 9, 2023
@rebron rebron removed the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants