Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verified checkmark icon is transparent rather than white in middle #2859

Closed
Miyayes opened this issue Jan 8, 2019 · 4 comments
Closed

Verified checkmark icon is transparent rather than white in middle #2859

Miyayes opened this issue Jan 8, 2019 · 4 comments
Assignees
@rossmoody
Labels
feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.61.x - Release ...

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 8, 2019

The verified checkmark icon in brave://rewards is transparent rather than white in the middle. Consequently, when it’s overlaid atop a favicon as it is in brave://rewards, it can be difficult to see, as the underlying favicon shows through the checkmark.
@rossmoody rossmoody self-assigned this Jan 8, 2019
@rossmoody
Copy link
Contributor

image 1

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 8, 2019
@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Jan 9, 2019
@rossmoody rossmoody mentioned this issue Jan 24, 2019
Merged
@NejcZdovc NejcZdovc reopened this Jan 30, 2019
@NejcZdovc
Copy link
Contributor

reopening as we need to pull this changes into brave-core. cc @rossmoody

@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.61.x - Dev Jan 31, 2019
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jan 31, 2019 •
edited
Loading

will be pulled in as brave/brave-core#1525 updates UI hash, setting the same milestone as #3103

@btlechowski
Copy link

btlechowski commented Feb 25, 2019 •
edited by GeetaSarvadnya
Loading

Verification passed on

Brave 0.61.37 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

image

Verification passed on

Brave 0.61.40 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux mint
  • Verified the description mentioned in the issue
    image

Verified passed with

Brave 0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X
  • Verified scenario in issue description
    screen shot 2019-03-04 at 2 37 46 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rossmoody rossmoody

Labels
feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.61.x - Release (Release Channel)
Development

No branches or pull requests
6 participants
@NejcZdovc @Miyayes @LaurenWags @rossmoody @btlechowski @GeetaSarvadnya