Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmark bar should be Bookmarks bar in brave://settings/appearance #28590

Closed
stephendonner opened this issue Feb 17, 2023 · 2 comments · Fixed by brave/brave-core#17274
Closed

Bookmark bar should be Bookmarks bar in brave://settings/appearance #28590

stephendonner opened this issue Feb 17, 2023 · 2 comments · Fixed by brave/brave-core#17274
Assignees
@spylogsster
Labels
bug needs-text-change This change requires some careful wording. OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.49.x - Release

Comments

@stephendonner
Copy link

Description

Bookmark bar should be Bookmarks bar in brave://settings/appearance

Steps to Reproduce

  1. install 1.50.43
  2. launch Brave
  3. open brave://settings/appearance
  4. set Show bookmarks to Only on the new tab page
  5. read the descriptive text
  6. set Show bookmarks to Never
  7. read the descriptive text

Actual result:

Bookmark bar Bookmarks bar
Screen Shot 2023-02-17 at 10 23 27 AM Screen Shot 2023-02-17 at 10 23 38 AM

Expected result:

Bookmarks bar

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

cc @brave/qa-team @rebron @spylogsster @simonhong
@stephendonner stephendonner added bug needs-text-change This change requires some careful wording. QA/Yes OS/Desktop labels Feb 17, 2023
@stephendonner stephendonner mentioned this issue Feb 17, 2023
Closed
@spylogsster spylogsster self-assigned this Feb 17, 2023
@spylogsster spylogsster mentioned this issue Feb 17, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 18, 2023
@brave-builds brave-builds mentioned this issue Feb 21, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.49.108 or higher for 1.49.x verification 👍

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (x86_64)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS macOS Version 11.7.4 (Build 20G1120)

Steps:

  1. installed 1.49.108
  2. launched Brave
  3. opened brave://settings/appearance
  4. changed the value of the Show bookmarks option to each of its values
  5. examined the descriptive text

Confirmed it now reads Bookmarks bar... in each of the cases

Always Never Only on the new tab page
Screen Shot 2023-02-23 at 1 47 42 AM Screen Shot 2023-02-23 at 1 47 48 AM Screen Shot 2023-02-23 at 1 47 54 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
bug needs-text-change This change requires some careful wording. OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

Renamed Bookmark -> Bookmarks brave/brave-core
4 participants
@stephendonner @kjozwiak @spylogsster @brave-builds