Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiat value showing 0 when having the same tokens on different chains #28753

Closed
Douglashdaniel opened this issue Feb 24, 2023 · 1 comment · Fixed by brave/brave-core#17367
Closed
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@Douglashdaniel
Copy link

Description

If you add a multiple of the same tokens on different chains and one of them doesn't have a balance, the fiat value will show 0.00 for the one that does have a balance.

Steps to Reproduce

  1. Add a token that has a balance on a L2 chain
  2. Now add that same token on a L1 chain without a balance
  3. The L2 fiat balance will show 0.00

Actual result:

Before.mov

Expected result:

Should show the fiat balance.

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@Douglashdaniel Douglashdaniel added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Feb 24, 2023
@Douglashdaniel Douglashdaniel self-assigned this Feb 24, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Feb 24, 2023
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Feb 24, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Feb 25, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 25, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.50.91 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Linux
28753.mp4

Verification passed on

Brave 1.50.91 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1344)
28753.mp4

Verification passed on

Brave 1.50.91 Chromium: 111.0.5563.64 (Official Build) beta (arm64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 13.0 (Build 22A380)
28753.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants