Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-contribute table is cleared after reconcile when rewards are off #2891

Closed
btlechowski opened this issue Jan 10, 2019 · 1 comment
Closed

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Clean profile
  2. Run Brave with flag --rewards=staging=true,reconcile-interval=2
  3. Enable rewards brave://rewards and claim the grant
  4. Open kjozwiakstaging.github.io in a new tab and stay on it for 10s to add it to a-c table
  5. Disable rewards
  6. Wait till the reconcile-interval is passed (2 minutes)
  7. Enable rewards
  8. Reload brave://rewards

Note: same happens when auto-contribute is off

Actual result:

auto-contribute table is cleared

Expected result:

auto-contribute table is not cleared based on #2804 (comment)

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

cc @NejcZdovc @mandar-brave @brave/legacy_qa

@btlechowski
Copy link
Author

I misunderstood @NejcZdovc comment. Closing the issue as invalid.

@btlechowski btlechowski modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 10, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 8, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants