Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected ads notification shown when changing application focus #2898

Closed
btlechowski opened this issue Jan 10, 2019 · 3 comments
Closed

unexpected ads notification shown when changing application focus #2898

btlechowski opened this issue Jan 10, 2019 · 3 comments

Comments

@btlechowski
Copy link

btlechowski commented Jan 10, 2019

Steps to Reproduce

  1. Clean profile
  2. Enable rewards and ads
  3. Open new tab and load https://hotel-deals.club/
  4. Focus Brave
  5. Wait 30 seconds
  6. Focus another application

Optional:
7. Wait 30 seconds
8. Focus Brave

Actual result:

IMPORTANT: those notifications can exceed the max number of ads per hour
IMPORTANT: those notifications are always triggered thus the system can be gamed.

Focus change: Brave->Other App
this one doesn't look good, because the ad notification will be shown when Other App is in focus. Looks like Other App's notification.
ads 2

Focus change: Other App->Brave
ads 1

Expected result:

Only show ads notification when Brave is in focus.
Do not exceed the max number of ads per hour

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.60.9 Chromium: 72.0.3626.28 (Official Build) dev (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows

Reproduced on Windows 7 and Windows 10

cc: @bridiver @jsecretan @brave/legacy_qa

@btlechowski
Copy link
Author

After further investigation it seems that the issue only reproduces when iab.com is opened in one of the tabs. The behavior seems intentional. Closing as invalid.

@btlechowski btlechowski modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 14, 2019
@archlemon
Copy link

@bridiver
Copy link
Contributor

@archlemon the ad notifications are not related to the active tab. They are triggered by a background mechanism and they can only be globally disabled/enabled. Any site settings to disable html5 notifications still apply as normal.

@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants