Support sync #29

bbondy · 2017-12-05T20:03:48Z

No description provided.

cezaraugusto · 2018-03-29T22:58:50Z

SergeyZhukovsky · 2018-04-03T21:32:53Z

Nice art!!! :)

AlexeyBarabash · 2018-06-15T09:48:10Z

Here is a current status

[+]   done
[+/-] needs to be polished
[]    not done yet
() <- Fibonacci points, 21 is the most complex

[+/-] (5) Run sync-js library
   [] (1) patch of TabStripModel::AddWebContents to make hide tab chrome://bravesynclib/ holding sync-js lib
   [] (3, opt) organize interaction without passing json, but raw objects, not sure if possible
   [+] (3) query objects from brave sync backend
   [] (8, opt) run js lib with V8 instead of WebUI, but js lib require 'chrome' and 'window' objects not available for direct V8 run.
   [] (1) organize dependancy in git 

[+/-] (3) Web UI
   [+] (1) simple page for 'New to sync'
   [+] (1) simple page for 'Connect to sync chain'
   [+] save/load Brave sync preferences
   [] (1) simple page for sync settings // in progress
   [] (5) QR code way for mobile devices
   [] (?) pretty Brave-styled UI

[] (13) Connecting Chromium-sync backend
   [+] (5) finding points to attach `GetUpdatesProcessor::ProcessResponse`  
   [+] (8) forcing single bookmark being created
   [] (13) finding conversion way Chromium Ids <=> Brave Ids, it may happend this is not possible, then go with regular sync lib integration.

[] (8) Automated tests

bbondy · 2018-08-16T18:52:37Z

@AlexeyBarabash could you provide a new update similar to the one from Jun 15th?

AlexeyBarabash · 2018-08-17T09:14:16Z

@bbondy

[+]   done
[+/-] needs to be polished
[]    not done yet
() <- Fibonacci points, 21 is the most complex

[+/-] (5) Run sync-js library
   [N/A] (1) patch of TabStripModel::AddWebContents to make hide tab chrome://bravesynclib/ holding sync-js lib
   [N/A] (3, opt) organize interaction without passing json, but raw objects, not sure if possible
   [+] (3) query objects from brave sync backend
   [N/A] (8, opt) run js lib with V8 instead of WebUI, but js lib require 'chrome' and 'window' objects not available for direct V8 run.
   [+] (1) organize dependancy in git 
   [] run sync-js as a extension background page
      [+] (1) Brave Sync Extension
      [+] (2) BraveSyncClient interface
      [+] (3) Brave Sync Extension resources packing // done by @bridiver
      [] (3) js-sync-lib methods with strict arguments on call execution browser<=>extension // in progress

[+/-] Objects synchronization
   [+/-] (3) bookmarks
     [] (5) ordering
   [+] devices
   [] (3) history
   [] (3) settings

[+/-] (3) Web UI
   [+] (1) simple page for 'New to sync'
   [+] (1) simple page for 'Connect to sync chain'
   [+] save/load Brave sync preferences
   [+] (1) simple page for sync settings 
   [+] (5) QR code way for mobile devices
   [+] (1) secret words way for desktops
   [] (?) pretty Brave-styled UI // in progress by @cezaraugusto

[] (13) Connecting Chromium-sync backend
   [+] (5) finding points to attach `GetUpdatesProcessor::ProcessResponse`  
   [+] (8) forcing single bookmark being created
   [] (13) finding conversion way Chromium Ids <=> Brave Ids, it may happend this is not possible, then go with regular sync lib integration.

[] (8) Automated tests

AlexeyBarabash · 2018-09-03T19:46:50Z

@bbondy

[+]   done
[+/-] needs to be polished
[]    not done yet
() <- Fibonacci points, 21 is the most complex

[+/-] (5) Run sync-js library
   [N/A] (1) patch of TabStripModel::AddWebContents to make hide tab chrome://bravesynclib/ holding sync-js lib
   [N/A] (3, opt) organize interaction without passing json, but raw objects, not sure if possible
   [+] (3) query objects from brave sync backend
   [N/A] (8, opt) run js lib with V8 instead of WebUI, but js lib require 'chrome' and 'window' objects not available for direct V8 run.
   [+] (1) organize dependancy in git 
   [+] run sync-js as a extension background page
      [+] (1) Brave Sync Extension
      [+] (2) BraveSyncClient interface
      [+] (3) Brave Sync Extension resources packing // done by @bridiver
      [+] (3) js-sync-lib methods with strict arguments on call execution browser<=>extension 

[] Misc
   [] (1) per-profile sync // in progress
   [] (3) threading
   [+] (1) rebase to cr70

[+/-] Objects synchronization
   [+/-] (3) bookmarks
     [] (5) ordering
   [+] devices
   [] (3) history
   [] (3) settings

[+/-] (3) Web UI
   [+] (1) simple page for 'New to sync'
   [+] (1) simple page for 'Connect to sync chain'
   [+] save/load Brave sync preferences
   [+] (1) simple page for sync settings 
   [+] (5) QR code way for mobile devices
   [+] (1) secret words way for desktops
   [] (?) pretty Brave-styled UI // in progress by @cezaraugusto

[] (13) Connecting Chromium-sync backend
   [+] (5) finding points to attach `GetUpdatesProcessor::ProcessResponse`  
   [+] (8) forcing single bookmark being created
   [] (13) finding conversion way Chromium Ids <=> Brave Ids, it may happend this is not possible, then go with regular sync lib integration.

[] (8) Automated tests

AlexeyBarabash · 2018-09-18T07:48:42Z

current update

[+]   done
[+/-] needs to be polished
[]    not done yet
() <- Fibonacci points, 21 is the most complex

[+/-] (5) Run sync-js library
   [N/A] (1) patch of TabStripModel::AddWebContents to make hide tab chrome://bravesynclib/ holding sync-js lib
   [N/A] (3, opt) organize interaction without passing json, but raw objects, not sure if possible
   [+] (3) query objects from brave sync backend
   [N/A] (8, opt) run js lib with V8 instead of WebUI, but js lib require 'chrome' and 'window' objects not available for direct V8 run.
   [+] (1) organize dependancy in git 
   [+] run sync-js as a extension background page
      [+] (1) Brave Sync Extension
      [+] (2) BraveSyncClient interface
      [+] (3) Brave Sync Extension resources packing // done by @bridiver
      [+] (3) js-sync-lib methods with strict arguments on call execution browser<=>extension 

[] Misc
   [+] (1) per-profile sync
   [+] (3) threading
   [+] (1) rebase to cr70

[+/-] Objects synchronization
   [+/-] (3) bookmarks
     [] (5) ordering // in progress
   [+] devices
   [] (3) history
   [] (3) settings

[+/-] (3) Web UI
   [+] (1) simple page for 'New to sync'
   [+] (1) simple page for 'Connect to sync chain'
   [+] save/load Brave sync preferences
   [+] (1) simple page for sync settings 
   [+] (5) QR code way for mobile devices
   [+] (1) secret words way for desktops
   [] (?) pretty Brave-styled UI // in progress by @cezaraugusto

[] (13) Connecting Chromium-sync backend
   [+] (5) finding points to attach `GetUpdatesProcessor::ProcessResponse`  
   [+] (8) forcing single bookmark being created
   [] (13) finding conversion way Chromium Ids <=> Brave Ids, it may happend this is not possible, then go with regular sync lib integration.

[] (8) Automated tests

czhang03 · 2018-10-30T17:37:47Z

Is sync expected in version 1.x or version 0.57?

bbondy · 2018-10-30T19:27:57Z

0.57.x however we are only putting issues in milestones once they are merged.

czhang03 · 2018-11-13T00:51:41Z

Can we get an update on this please? I can't wait to see the progress on this one.

bsclifton · 2018-11-13T20:08:24Z

@chantisnake code has been merged- it's live in development channel (although, we're due for a build). It currently points at a staging environment and is hidden behind a command line flag. According to our release schedule, 0.57.x is due to be released ~Dec 4th

bbondy · 2018-11-21T02:33:01Z

0.57.x will have sync behind a command line flag that you need to specify to see the UI. For 0.58.x we'll remove the need for the command line flag.

rahilwazir · 2018-11-21T13:39:15Z

@bbondy @bsclifton

How am I suppose to use sync feature?

Running Version 0.58.9 Chromium: 71.0.3578.53 (Official Build) dev (64-bit)

bsclifton · 2018-11-21T19:50:26Z

@rahilwazir that section is confusing and we want to rename / move that section (this was previously called Privacy and security settings but we renamed/moved with Chromium 71). It should be on @rebron 's radar- but I don't think we have an issue captured yet. In Chrome / Chromium, you can enable Google sync there (but it doesn't show in Brave because we intentionally removed it)

The only way to enable sync (Brave Sync) at the moment is to pass in the command line flag --enable-brave-sync when launching Brave. You should then see a new item in the hamburger menu where you can activate it 😄

srirambv · 2018-12-11T09:37:16Z

Verification passed on

Brave	0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Linux

Verified Sync option available in hamburger menu
Verified settings has a dedicated section for sync which redirects to brave://bravesync
Verified able to create a new sync chain
Verified able to join an existing sync chain
Verified able to reset and recreate a new sync chain
Verified able to remove other devices joined in sync chain
Verified able to sync bookmarks to other devices
Verified able to sync bookmarks added on other devices

Verification passed on

Brave	0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Windows

Verified Sync option available in hamburger menu
Verified settings has a dedicated section for sync which redirects to brave://bravesync
Verified able to create a new sync chain
Verified able to join an existing sync chain
Verified able to reset and recreate a new sync chain
Verified able to remove other devices joined in sync chain
Verified able to sync bookmarks to other devices
Verified able to sync bookmarks added on other devices

Verified passed with

Brave	0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Mac OS X

Verified Sync option available in hamburger menu
Verified settings has a dedicated section for sync which redirects to brave://bravesync
Verified able to create a new sync chain
Verified able to join an existing sync chain
Verified able to reset and recreate a new sync chain
Verified able to remove other devices joined in sync chain
Verified able to sync bookmarks to other devices
Verified able to sync bookmarks added on other devices

bbondy added this to the Milestone 3: To be able to market and release 1.0 milestone Dec 5, 2017

cezaraugusto assigned cezaraugusto and SergeyZhukovsky Mar 29, 2018

bbondy assigned AlexeyBarabash and unassigned cezaraugusto and SergeyZhukovsky Jun 6, 2018

AlexeyBarabash mentioned this issue Jul 6, 2018

Sync brave/brave-core#226

Merged

bsclifton added browser-laptop-parity feature/sync labels Aug 7, 2018

AlexeyBarabash mentioned this issue Aug 17, 2018

Remove Background Sync content setting options #366

Closed

tildelowengrimm mentioned this issue Aug 28, 2018

Consider integrating with Google sync (bookmark / extension settings) #839

Closed

bsclifton mentioned this issue Sep 28, 2018

How can I enable sync in Version 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit) #1265

Closed

bbondy modified the milestones: Releasable builds 0.55.x, 1.0 (0.56.x) Oct 2, 2018

rebron modified the milestones: 1.0, 0.56.x - Beta Oct 16, 2018

rebron removed this from the 0.57.x - Dev milestone Oct 30, 2018

bbondy added this to the 1.x Backlog milestone Oct 30, 2018

bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 30, 2018

bbondy closed this as completed Nov 21, 2018

bbondy modified the milestones: 1.x Backlog, 0.58.x - Beta Dec 2, 2018

bbondy added the QA/Yes label Dec 2, 2018

srirambv added the QA Pass-Linux label Dec 11, 2018

GeetaSarvadnya added the QA Pass-Win64 label Dec 11, 2018

LaurenWags added the QA Pass-macOS label Dec 12, 2018

kjozwiak added the release-notes/exclude label Dec 18, 2018

kjozwiak mentioned this issue Jan 31, 2019

Enabling Sync by default #3180

Closed

iefremov mentioned this issue Nov 27, 2020

CryptoDotComAPIBrowserTest.NewTabHasCryptoDotComAPIAccess asan failure #12923

Closed

JeetChaudhari mentioned this issue Aug 29, 2021

FDM extension on Brave not working #12202

Open

tmancey mentioned this issue Feb 22, 2022

AddressSanitizer: heap-use-after-free brave_shields::AdBlockRegionalServiceManager #21228

Closed

bridiver mentioned this issue Mar 31, 2022

BraveMainDelegate is not used on upstream browser tests #22021

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support sync #29

Support sync #29

bbondy commented Dec 5, 2017

cezaraugusto commented Mar 29, 2018

SergeyZhukovsky commented Apr 3, 2018

AlexeyBarabash commented Jun 15, 2018

bbondy commented Aug 16, 2018

AlexeyBarabash commented Aug 17, 2018

AlexeyBarabash commented Sep 3, 2018

AlexeyBarabash commented Sep 18, 2018

czhang03 commented Oct 30, 2018

bbondy commented Oct 30, 2018

czhang03 commented Nov 13, 2018

bsclifton commented Nov 13, 2018

bbondy commented Nov 21, 2018

rahilwazir commented Nov 21, 2018

bsclifton commented Nov 21, 2018 •

edited

Loading

srirambv commented Dec 11, 2018 •

edited by LaurenWags

Loading

Support sync #29

Support sync #29

Comments

bbondy commented Dec 5, 2017

cezaraugusto commented Mar 29, 2018

SergeyZhukovsky commented Apr 3, 2018

AlexeyBarabash commented Jun 15, 2018

bbondy commented Aug 16, 2018

AlexeyBarabash commented Aug 17, 2018

AlexeyBarabash commented Sep 3, 2018

AlexeyBarabash commented Sep 18, 2018

czhang03 commented Oct 30, 2018

bbondy commented Oct 30, 2018

czhang03 commented Nov 13, 2018

bsclifton commented Nov 13, 2018

bbondy commented Nov 21, 2018

rahilwazir commented Nov 21, 2018

bsclifton commented Nov 21, 2018 • edited Loading

srirambv commented Dec 11, 2018 • edited by LaurenWags Loading

bsclifton commented Nov 21, 2018 •

edited

Loading

srirambv commented Dec 11, 2018 •

edited by LaurenWags

Loading