Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Longer browser profile names are shown in brave://welcome pages #29046

Closed
MadhaviSeelam opened this issue Mar 14, 2023 · 1 comment · Fixed by brave/brave-core#17595
Closed

Comments

@MadhaviSeelam
Copy link

Description

It appears there is a browser profile name change occurred with 1.50.x as the profiles names shown are very long that included browser name for all the detected browsers in the brave://welcome - Select profile to import - screen. eg. Chrome Person 1 is shown Google Person 1 - Google Chrome. Profile names should be displayed same as in 1.49.x Chrome Person 1

Steps to Reproduce

  1. Install 1.50.x
  2. launch Brave
  3. select Set Brave as default browser
  4. select Google Chrome
  5. verify profile name

Actual result:

Profile names shown as
Google Chrome Person 1 - Google Chrome
Google Chrome Person 2 - Google Chrome

image

Expected result:

Chrome Person 1 and Chrome Person 2

image

Reproduces how often:

Yes

Brave version (brave://version info)

Brave 1.50.90 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1265)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@spylogsster @rebron
@stephendonner
Copy link

stephendonner commented Apr 3, 2023

Verified PASSED using

Brave 1.51.76 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Windows 10 Version 22H2 (Build 19045.2788)

Followed the original steps to reproduce.

Verified browser-profile names no longer repeat

Confirmed fixed in 1.51.76:

Google Chrome Dev Google Chrome Beta Google Chrome
image (2) image (1) image

Reproduced the issue in 1.50.130:

Google Chrome Dev Google Chrome Beta Google Chrome
image (1) image image (2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants