Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts can't be unblocked with custom filters #29215

Closed
wooque opened this issue Mar 21, 2023 · 1 comment
Closed

Scripts can't be unblocked with custom filters #29215

wooque opened this issue Mar 21, 2023 · 1 comment
Labels
closed/duplicate Issue has already been reported OS/Desktop privacy

Comments

@wooque
Copy link

wooque commented Mar 21, 2023

Description

I want to block scripts in general and only allow certain scripts to be run. For test I blocked scripts on https://boards.4channel.org/g/catalog, and added exceptions in custom filters

@@||s.4cdn.org/js/*$script
@@||boards.4channel.org^$inline-script

but that didn't work.

Steps to Reproduce

  1. Block scripts on https://boards.4channel.org/g/catalog
  2. Add custom filters
@@||s.4cdn.org/js/*$script
@@||boards.4channel.org^$inline-script

Actual result:

Scripts are still blocked

Expected result:

Scripts are unblocked

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? /
  • Can you reproduce this issue with the nightly channel? /

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? /
  • Does the issue resolve itself when disabling Brave Rewards? /
  • Is the issue reproducible on the latest version of Chrome? /

Miscellaneous Information:

@antonok-edm
Copy link
Collaborator

@wooque this is by design, we don't want users who enable script blocking to be affected by exceptions written specifically for selective adblock filtering (which can be shipped by upstream filter list authors).

The good news though, is that we recently landed selective script blocking exceptions through the shields panel in Nightly - see brave/brave-core#17221 for details.

@antonok-edm antonok-edm added the closed/duplicate Issue has already been reported label Mar 21, 2023
@antonok-edm antonok-edm added this to the Closed / Dupe / Invalid milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported OS/Desktop privacy
Projects
None yet
Development

No branches or pull requests

2 participants