Remove "Ready to start earning?" modal and update custodial selection modal

[Miyayes]

Description

Consolidate these two modals into a single step (keep the custodial selection modal).

On the custodial selection modal:

(1) Remove "If you already have..." paragraph

(2) Add these bullet points:

But change "Tip your favorite..." to "Send on-demand contributions to..."

(3) Modify disclaimer at bottom to say:

Custodial account providers are required to verify your identity, which may include submitting a photo ID. See the Brave Rewards Privacy Policy. See here to learn more about BAT.

[LaurenWags]

Verified with

Brave | 1.52.86 Chromium: 113.0.5672.77 (Official Build) beta (x86_64)
-- | --
Revision | c4236862955e005c2187105415ac4a2ecf86dff1-refs/branch-heads/5672_62@{#3}
OS | macOS Version 13.3.1 (Build 22E261)

Verified the test plan from the PR, brave/brave-core#17949 (comment), for the below scenarios on this modal.

2 custodians available - PASSED

Confirmed that country selected prior to joining (staging) Rewards (I used United States) is in the allow list for both Uphold and Gemini on staging:

[ RESPONSE - OnResponse ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.220262,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US"],"block":[]},"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US","IN"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","payoutDate":"","unverified":"complete","uphold":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"vbatDeadline":"2023-02-10T00:00:00Z","vbatExpired":false}

Confirmed modal looked like the one in the PR:

Uphold custodian available, Gemini unavailable - PASSED

Confirmed that country selected prior to joining (staging) Rewards (I used India) is in the allow list for Uphold but not Gemini on staging:

[ RESPONSE - OnResponse ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.220262,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US"],"block":[]},"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US","IN"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","payoutDate":"","unverified":"complete","uphold":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"vbatDeadline":"2023-02-10T00:00:00Z","vbatExpired":false}

Confirmed modal looked like the one in the PR:

Gemini custodian available, Uphold unavailable - PASSED

Used Charles Proxy to rewrite the response body for the parameters endpoint so that United Kingdom (GB) was not in the "allow" list for Uphold:

[ RESPONSE - OnResponse ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.211087,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US"],"block":[]},"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","US","IN"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","payoutDate":"","unverified":"complete","uphold":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"vbatDeadline":"2023-02-10T00:00:00Z","vbatExpired":false}

Confirmed modal looked like the one in the PR:

Only 1 custodian (bitFlyer) available - PASSED

Confirmed that country selected prior to joining (staging) Rewards (Japan) is in the allow list for bitFlyer on staging:

[ RESPONSE - OnResponse ]
> Url: https://api.rewards.bravesoftware.com/v1/parameters
> Result: Success
> HTTP Code: 200
> Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.210463,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US"],"block":[]},"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","GB","US","IN"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","payoutDate":"","unverified":"complete","uphold":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"vbatDeadline":"2023-02-10T00:00:00Z","vbatExpired":false}

Confirmed modal looked like the one in the PR:

[hffvld]

Verified on Google Pixel 7 using version(s):

Device/OS: Google Pixel 7 [panther_beta-user 14 UPB2.230407.014 release-keys]
Brave build: 1.52.110
Chromium: 114.0.5735.35 (Official Build) (64-bit)
Revision: 7429f911c043513bd013a56876f67313d91dcbfd-refs/branch-heads/5672_132@{#8}

---

STEPS:

1. Clean profile
2. Enable Rewards > Select country
3. Tap Connect account button in Rewards panel

ACTUAL RESULTS:

• Verified that Connect modal looks/behaves as described in issue

2 custodians available (US) - PASSED

1	2

Uphold custodian available, Gemini unavailable (India) - PASSED

1	2

Only 1 custodian (bitFlyer) available (Japan) - PASSED

1	2