Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show "All Networks" assets on edit visible assets dialog #29555

Closed
Tracked by #29552
Pavneet-Sing opened this issue Apr 6, 2023 · 1 comment · Fixed by brave/brave-core#18096
Closed
Tracked by #29552

Show "All Networks" assets on edit visible assets dialog #29555

Pavneet-Sing opened this issue Apr 6, 2023 · 1 comment · Fixed by brave/brave-core#18096
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.52.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Apr 6, 2023 •
edited
Loading

Show assets of all network on edit-visible dialog. (Previously, Edit visible dialog was showing assets of default network when all network is selected on Portfolio)
@Pavneet-Sing Pavneet-Sing mentioned this issue Apr 6, 2023
Closed
@Pavneet-Sing Pavneet-Sing self-assigned this Apr 6, 2023
@Pavneet-Sing Pavneet-Sing added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support labels Apr 6, 2023
@Pavneet-Sing Pavneet-Sing added this to Web3 Apr 6, 2023
@Pavneet-Sing Pavneet-Sing moved this to In Progress in Web3 Apr 6, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Apr 17, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Apr 18, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 18, 2023
@Pavneet-Sing Pavneet-Sing added the OS/Android Fixes related to Android browser functionality label Apr 19, 2023
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.52.92 x64 beta build

  • Verified steps from brave/brave-core#18096
  • Verified able to see all tokens in edit visible asset dialog
  • Verified filtering network in portfolio also filters visible asset lists
  • Verified NFT's can also be filtered based on network
29555.mp4

@kjozwiak kjozwiak mentioned this issue May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

Show "All Networks" assets on edit visible assets dialog brave/brave-core
3 participants
@Pavneet-Sing @srirambv @brave-builds