Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Enable NFT auto-discovery" popup #29648

Closed
muliswilliam opened this issue Apr 12, 2023 · 1 comment · Fixed by brave/brave-core#18010
Closed

Add "Enable NFT auto-discovery" popup #29648

muliswilliam opened this issue Apr 12, 2023 · 1 comment · Fixed by brave/brave-core#18010
Assignees
@muliswilliam
Labels
feature/web3/wallet/core feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.52.x - Release

Comments

@muliswilliam
Copy link

No description provided.

@muliswilliam muliswilliam converted this from a draft issue Apr 12, 2023
@muliswilliam muliswilliam self-assigned this Apr 12, 2023
@muliswilliam muliswilliam mentioned this issue Apr 12, 2023
Merged
25 tasks
@muliswilliam muliswilliam added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 12, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Apr 17, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 17, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (64-bit)
Revision c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS Linux
  • Verified steps from brave/brave-core#18010
  • Verified when switching to NFT tab for the first time shows a popup to enable NFTs automatically
  • Verified selecting Yes proceed enables the auto-discovery settings in brave://settings/web3 and auto-adds any NFTs owned by the wallet address
29648.mp4

Verification passed on

Brave 1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (64-bit)
Revision c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS Windows 11 Version 22H2 (Build 22621.1702)
  • Verified steps from brave/brave-core#18010
  • Verified when switching to NFT tab for the first time shows a popup to enable NFTs automatically
  • Verified selecting Yes proceed enables the auto-discovery settings in brave://settings/web3 and auto-adds any NFTs owned by the wallet address
29648.mp4

Verification passed on

Brave 1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (arm64)
Revision c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#18010
  • Verified when switching to NFT tab for the first time shows a popup to enable NFTs automatically
  • Verified selecting Yes proceed enables the auto-discovery settings in brave://settings/web3 and auto-adds any NFTs owned by the wallet address
29648.mov

@LaurenWags LaurenWags mentioned this issue May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet/core feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet) Add a modal for enabling NFT auto discovery brave/brave-core
3 participants
@srirambv @brave-builds @muliswilliam