Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect response value when ads is enabled after 48 hours but before 72 hours #29653

Closed
GeetaSarvadnya opened this issue Apr 12, 2023 · 4 comments

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #28109
Incorrect response value when ads is enabled after 48 hours and before 72 hours

Steps to Reproduce

  1. Clean profile 1.51.x
  2. Open brave://local-state file
  3. Confirm that the metrics Brave.Rewards.EnabledInstallationTime is not shown in the local state file
  4. Close the browser, set the sys clock ahead by 48+ hours but before 72 hours
  5. Relaunch browser and enable rewards/Ads
  6. Reload brave://local-state file and ensure that the metrics Brave.Rewards.EnabledInstallationTime response value is 4 instead of 3
  7. Open charles and wait until the metrics is sent over the network via Charles
  8. Confirmed that the metrics is listed under the host p3a-json.brave.com over the network and the metrics_value is 4 instead of 3

Actual result:

Incorrect response value when ads is enabled after 48 hours and before 72 hours

p3a-json.brave.com brave://local-state
image image

Expected result:

Value should be 3

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.51.79 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Windows 10 Version 21H2 (Build 19044.2728)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @DJAndries @mattmcalister

@GeetaSarvadnya
Copy link
Author

The issue is reproducible on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.51.79

@GeetaSarvadnya GeetaSarvadnya added the OS/Android Fixes related to Android browser functionality label Apr 12, 2023
@GeetaSarvadnya GeetaSarvadnya changed the title Incorrect response value when ads is enabled after 48 hours and before 72 hours Incorrect response value when ads is enabled after 48 hours but before 72 hours Apr 12, 2023
@DJAndries
Copy link
Collaborator

Tested with 50 hours and 71 hours, could not reproduce

@GeetaSarvadnya
Copy link
Author

@DJAndries: Thanks for checking from your end. Let me retest the issue and post my observations.

@GeetaSarvadnya
Copy link
Author

Works as expected hence closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants