Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise publisher update feedback #2973

Closed
NejcZdovc opened this issue Jan 15, 2019 · 3 comments · Fixed by brave/brave-core#1457
Closed

Optimise publisher update feedback #2973

NejcZdovc opened this issue Jan 15, 2019 · 3 comments · Fixed by brave/brave-core#1457
Assignees
@NejcZdovc
Labels
dev-concern feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No QA/Test-Plan-Required QA/Yes release-notes/exclude
Milestone
0.61.x - Release ...

Comments

@NejcZdovc
Copy link
Contributor

  • onPublisherInfoUpdated calls synopsis
  • onSetPublisherInfo calls synopsis

Flow should be more optimised.
@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 15, 2019
@NejcZdovc NejcZdovc self-assigned this Jan 15, 2019
@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Jan 15, 2019
@NejcZdovc
Copy link
Contributor Author

There is also a lot of responses send to the panel that are the same and that should be reduced just to ones that are actually different and needed. Most of the code that is responsible for sending this out is inside bat_get_media.

This was referenced Jan 22, 2019
Merged
Merged
@NejcZdovc NejcZdovc mentioned this issue Feb 1, 2019
Merged
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.61.x - Dev Feb 1, 2019
@btlechowski
Copy link

@NejcZdovc Could you provide test plan for this issue or set it to QA/No if testing is not needed?

@NejcZdovc
Copy link
Contributor Author

@btlechowski added QA/No flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
dev-concern feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No QA/Test-Plan-Required QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.61.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Publisher updates flow brave/brave-core
3 participants
@rebron @NejcZdovc @btlechowski