Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Enable NFT auto-discovery" popup #29778

Closed
2 tasks done
Pavneet-Sing opened this issue Apr 17, 2023 · 1 comment · Fixed by brave/brave-core#18185
Closed
2 tasks done

Add "Enable NFT auto-discovery" popup #29778

Pavneet-Sing opened this issue Apr 17, 2023 · 1 comment · Fixed by brave/brave-core#18185
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.52.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Apr 17, 2023 •
edited by nuo-xu
Loading

Description

Tasks
Beta Give feedback
@Pavneet-Sing Pavneet-Sing added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality feature/web3/wallet/nft labels Apr 17, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Apr 17, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Apr 21, 2023
Merged
25 tasks
@HEagle18 HEagle18 moved this to In Review in Web3 Apr 21, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Apr 26, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 26, 2023
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.52.94 x64 Beta build

  • Verified steps from brave/brave-core#18185
  • Verified Learn more on the auto-discovery prompt and settings load https://github.com/brave/brave-browser/wiki/NFT-Discovery
  • Verified NFT discovery dialog is not shown once Enable/cancel is clicked
  • Verified NFTs are auto added to the visible list when NFT auto-discovery is enabled either via settings or via the NFT discovery prompt
29778.mp4

@kjozwiak kjozwiak mentioned this issue May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

Show NFT discovery dialog brave/brave-core
3 participants
@Pavneet-Sing @srirambv @brave-builds