Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loading on buy screen #30089

Closed
Pavneet-Sing opened this issue May 2, 2023 · 2 comments · Fixed by brave/brave-core#18438
Closed

Infinite loading on buy screen #30089

Pavneet-Sing opened this issue May 2, 2023 · 2 comments · Fixed by brave/brave-core#18438
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/include
Milestone
1.52.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented May 2, 2023 •
edited
Loading

Description

Infinite loading on buy screen (nightly).

Actual result

Screencast.from.02-05-23.02.01.07.PM.IST.webm

Expected result

Should show/load buy assets.

Issue reproduces how often

easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version? Y

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Version 1.53.10 Chromium: 113.0.5672.63 (Official Build) nightly (64-bit)
@Pavneet-Sing Pavneet-Sing added QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels May 2, 2023
@Pavneet-Sing Pavneet-Sing added this to Web3 May 2, 2023
@jamesmudgett jamesmudgett added priority/P4 Planned work. We expect to get to it "soon". priority/P3 The next thing for us to work on. It'll ride the trains. labels May 5, 2023
@jamesmudgett jamesmudgett moved this to Backlog in Web3 May 5, 2023
@muliswilliam muliswilliam moved this from Backlog to In Progress in Web3 May 10, 2023
@muliswilliam muliswilliam moved this from In Progress to In Review in Web3 May 10, 2023
@muliswilliam muliswilliam mentioned this issue May 10, 2023
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 May 11, 2023
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 11, 2023
@brave-builds brave-builds mentioned this issue May 11, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.52.100 or higher for 1.52.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.52.100 Chromium: 113.0.5672.92 (Official Build) beta (64-bit)
Revision b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS Linux
  • Verified steps from brave/brave-core#18438
  • Verified there is no constant loading on Buy screen
  • Verified Buy screen shows properly when navigated directly using routes in a new tab
30089.mp4

@LaurenWags LaurenWags mentioned this issue May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Fix Infinite loading on buy screen brave/brave-core
7 participants
@jamesmudgett @kjozwiak @Pavneet-Sing @srirambv @josheleonard @brave-builds @muliswilliam