Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome Wayland Fractional Scaling Regression #30137

Closed
Pythoner6 opened this issue May 4, 2023 · 35 comments
Closed

Gnome Wayland Fractional Scaling Regression #30137

Pythoner6 opened this issue May 4, 2023 · 35 comments
Labels
Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix closed/by-author OS/Desktop OS/Linux QA/No release-notes/exclude repros-on-chrome

Comments

@Pythoner6
Copy link

Description

Previously brave worked fine when org.gnome.mutter experimental-features was set to ['scale-monitor-framebuffer'] (necessary to get fractional scaling at the moment under gnome). Now if you set the display scaling to something larger than 100% (e.g. 150% or 200%), brave is not scaled properly, appearing much too large.

Steps to Reproduce

  1. gsettings set org.gnome.mutter experimental-features "['scale-monitor-framebuffer']"
  2. Set display scaling to something larger than 100%
  3. Install latest version of brave
  4. Set Preferred Ozone platform to Wayland under brave://flags
  5. Restart brave

Actual result:

Brave window is not sized properly, e.g. when it is "maximized" it takes up more than the full screen and is blurry.

Expected result:

Brave is sized properly according to the desktop scaling setting and not blurry.

Reproduces how often:

Consistently

Brave version (brave://version info)

Brave: 1.51.110 Chromium: 113.0.5672.77 (Official Build) (64-bit)
Revision: c4236862955e005c2187105415ac4a2ecf86dff1-refs/branch-heads/5672_62@{#3}
OS: Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    • Yes
  • Can you reproduce this issue with the beta channel?
    • Yes
  • Can you reproduce this issue with the nightly channel?
    • Yes

Other Additional Information:

  • Is the issue reproducible on the latest version of Chrome?
    • Haven't tested Chrome, but it is not reproducible in the latest version of chromium.
@h3nill
Copy link

h3nill commented May 4, 2023

same issue on KDE, downgraging to 1.50.125 fixes the issue.

@Pythoner6
Copy link
Author

Actually, in addition, setting the preferred ozone platform to wayland when the experimental mutter setting isn't enabled, but scaling is e.g. 200% is now also blurry, where it used to not be. Perhaps scaling in wayland may just be broken in general.

@rebron rebron added the OS/Linux label May 4, 2023
@ghost
Copy link

ghost commented May 4, 2023

have the same problem downgraded too also fixed it.

@ghost
Copy link

ghost commented May 4, 2023

Can we expect an update soon or must i, go to another browser the time next version come ? (since all browser continue to see wayland as second class citizen (not even tested before making update when ubuntu/fedora etc use it by default).

@jaylittle
Copy link

Actually, in addition, setting the preferred ozone platform to wayland when the experimental mutter setting isn't enabled, but scaling is e.g. 200% is now also blurry, where it used to not be. Perhaps scaling in wayland may just be broken in general.

No, more than likely that just means Brave is using XWayland (aka X11) instead of native Wayland.

@jaylittle
Copy link

jaylittle commented May 5, 2023

Can we expect an update soon or must i, go to another browser the time next version come ? (since all browser continue to see wayland as second class citizen (not even tested before making update when ubuntu/fedora etc use it by default).

FWIW I think we are close to seeing this issue resolved in Chromium based browsers. I tried the latest Chromium Dev browser yesterday and once I set the Ozone Platform setting to use Wayland, it handled fractional scaling (125%, ymmv with other settings) perfectly (no blurriness, Wayland rendering confirmed using xeyes) without anymore hacks of coaxing required on my part.

@Pythoner6
Copy link
Author

Actually, in addition, setting the preferred ozone platform to wayland when the experimental mutter setting isn't enabled, but scaling is e.g. 200% is now also blurry, where it used to not be. Perhaps scaling in wayland may just be broken in general.

No, more than likely that just means Brave is using XWayland (aka X11) instead of native Wayland.

Nope, just double checked using xeyes and brave is running with wayland (when I set the ozone platform to wayland), but the scaling is wrong and it seems blurry. Almost like brave is being rendered at the appropriate resolution, but then displayed at 2x the size it should be when scaling is 200%. This wasn't an issue with the previous version and isn't an issue with the latest chromium either, so brave is doing something to break wayland scaling right now. Brave is also blurry running using XWayland, but that's a separate known issue (and not so much the fault of brave from what I understand).

@eifr
Copy link

eifr commented May 5, 2023

I tried Chrome stable and the issue was present.
It was also occurring a few weeks ago when I tested it on Chrome nightly, but it appears to be resolved now (on nightly).

@Pythoner6
Copy link
Author

Hmm, interesting it'd be an issue on chrome, as it is not happening for me on chromium 113.0.5672.63 (Official Build) (64-bit)

@ghost
Copy link

ghost commented May 5, 2023

just hope it's fixed asap, it's unbearable the blurry even on X11

@spockfish
Copy link

@ghost
Copy link

ghost commented May 6, 2023

This is the corresponding thread at Fedora: https://discussion.fedoraproject.org/t/chrome-and-brave-with-ozone-wayland-fractional-scaling-stopped-working-on-f38/82077

i do not use the normal version since i'm forced (silverblue) to use flatpak due to my system, and the fedora "temporary" fix do not fix the problem in my case (or maybe i do not use iris).

Really hope an hotfix very soon.

@sepehr
Copy link

sepehr commented May 7, 2023

I experienced this after the update to the latest Flatpak Brave today. I don't use fractional scaling as that's just hell, just straightforward 200%.

On the latest Fedora, I have worked around this by downgrading from 1.51.110 to 1.50.125 and locking the version at the moment.

flatpak update --commit=2cbeea4c7ddb117f3680e6603bcf9cc799cf515f1e01ea7f1a3ff7e075115f94 com.brave.Browser

flatpak mask com.brave.Browser

@ghost
Copy link

ghost commented May 7, 2023

I experienced this after the update to the latest Flatpak Brave today. I don't use fractional scaling as that's just hell, just straightforward 200%.

On the latest Fedora, I have worked around this by downgrading from 1.51.110 to 1.50.125 and locking the version at the moment.

flatpak update --commit=2cbeea4c7ddb117f3680e6603bcf9cc799cf515f1e01ea7f1a3ff7e075115f94 com.brave.Browser

flatpak mask com.brave.Browser

Fixing the version is not really recommended since you will avoid all security fixes that come with update.

@ghost
Copy link

ghost commented May 7, 2023

I have found a temporary fix (remain little blurry but at least it work on wayland instead of X11 (battery drain etc)).

add : --force-device-scale-factor=1

@Pythoner6
Copy link
Author

Issue persists in latest version:

Brave: 1.51.114 Chromium: 113.0.5672.92 (Official Build) unknown (64-bit)
Revision: b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS: Linux

@ghost
Copy link

ghost commented May 10, 2023

Issue persists in latest version:

Brave: 1.51.114 Chromium: 113.0.5672.92 (Official Build) unknown (64-bit) Revision: b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10} OS: Linux

Same here

@rebron
Copy link
Collaborator

rebron commented May 10, 2023

https://bugs.chromium.org/p/chromium/issues/detail?id=1356014 Looks like a fix is on the way.

@rebron rebron added repros-on-chrome Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix release-notes/include QA/No labels May 10, 2023
@ghost
Copy link

ghost commented May 12, 2023

https://bugs.chromium.org/p/chromium/issues/detail?id=1356014 Looks like a fix is on the way.

Simple curiosity, if you where to guess, do we will have a fix in "days, weeks" ? (only to see if i bear it a little more or if i can take time to set up another browser the time the fix arrive in your hand to be pushed) ?

@eifr
Copy link

eifr commented May 13, 2023

https://bugs.chromium.org/p/chromium/issues/detail?id=1356014 Looks like a fix is on the way.

Simple curiosity, if you where to guess, do we will have a fix in "days, weeks" ? (only to see if i bear it a little more or if i can take time to set up another browser the time the fix arrive in your hand to be pushed) ?

Fixed for me in latest nightly, can anyone else test it

@fuelflo
Copy link

fuelflo commented May 14, 2023

//Yup, Brave Browser 113.1.53.37 nightly, seems to fix the problem for me.
Disregard, see comment below

@ghost
Copy link

ghost commented May 14, 2023

Yup, Brave Browser 113.1.53.37 nightly, seems to fix the problem for me.

i Guess it will reach stable soon so :) thanks to tell us.

@Pythoner6
Copy link
Author

Hmm, I'm still seeing the problem on 1.53.37. Or more specifically: with the experimental fractional scaling option enabled, scaling is still entirely wrong. With it disabled (and this seems to now be the case with even stable brave?) the window appears to be the correct scale, but is blurry (this is all running under native wayland, not through xwayland).

@Pythoner6
Copy link
Author

Also I think I see why I didn't run into this issue with upstream chromium: I've been using the flatpak version of chromium which has some patches applied, one of which might be fixing this issue https://github.com/flathub/org.chromium.Chromium/blob/master/patches/chromium/M113-Revert-Linux-Ozone-Wayland-Support-fractional-scale-v.patch

@fuelflo
Copy link

fuelflo commented May 14, 2023

@Pythoner6 you're right. I didn't set set preferred ozone platform to Wayland on the brave nightly install. When i set it manually to Wayland the scaling problem is back with Brave nightly 113.1.53.37, while there is no problem with google-chrome-beta Version 114.0.5735.26.
Maybe someone else could try to confirm this.

@Pythoner6
Copy link
Author

I haven't been able to test it, but it does look like the patch in the chromium flatpak I mentioned is from a commit in chromium upstream - just not one thats yet in a stable build I think. So I'm not surprised it'd be fixed in chrome beta.

@lubo
Copy link

lubo commented May 16, 2023

This is fixed in Chrome 113.0.5672.126.

@Pythoner6
Copy link
Author

Fixed in in the now released 1.51.118

@sepehr
Copy link

sepehr commented Jun 11, 2023

Experiencing this again on v1.52.122.

@koponomarenko
Copy link

I still get blurriness with Release v1.53.103 (Chromium 115.0.5790.32).

@alongwhile
Copy link

I'm experiencing this on Fedora Silverblue running Gnome Wayland. Both flatpak version and with rpm overlaid into the distro. Scaling looks fine until i force Wayland under ozone flags, then all text looks blurry and low res. Switching back to X11 under ozone doesn't even fix the problem!!

launching the rpm with brave-browser --force-device-scale-factor=1 does fix the problem but of course the UI and text are quite tiny. Hoping this can be resolved somehow?

@sepehr
Copy link

sepehr commented Oct 30, 2023

Thanks for the update @alongwhile. Was this the latest v1.59.124 Brave?

@alongwhile
Copy link

Thanks for the update @alongwhile. Was this the latest v1.59.124 Brave?

Yes. I tried both flatpak and rpm install and it happens on both. Had to delete all profile information to reset everything so it would stop. Avoiding wayland for now I guess until this is resolved

@CodeDead
Copy link

CodeDead commented Feb 14, 2024

Scaling is still not respecting the system settings on Fedora 39, with ozone / Wayland enabled using Brave v1.62.165
The issue is present in Chromium latest version as of this comment as well (v121.0.6167.160)

@sepehr
Copy link

sepehr commented May 19, 2024

Still experiencing this on Fedora 40, Flatpak-installed Version 1.66.110 Chromium: 125.0.6422.60 (Official Build) unknown (64-bit).

However, repo-installed version [Version 1.66.110 Chromium: 125.0.6422.60 (Official Build) (64-bit)](https://brave.com/latest/) works without any issues. Things are not blurry here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix closed/by-author OS/Desktop OS/Linux QA/No release-notes/exclude repros-on-chrome
Projects
None yet
Development

No branches or pull requests