Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect IPFS hints and display extension install prompt #3045

Closed
lidel opened this issue Jan 22, 2019 · 1 comment
Closed

Detect IPFS hints and display extension install prompt #3045

lidel opened this issue Jan 22, 2019 · 1 comment
Labels
closed/duplicate Issue has already been reported feature/web3/ipfs priority/P4 Planned work. We expect to get to it "soon".

Comments

@lidel
Copy link

lidel commented Jan 22, 2019

This task was extracted from "Notes on bringing IPFS to Brave": #819 (comment)
Please read the link above before this one.

ps. this work should happen in ipfs branch

How to onboard IPFS users?

  • We don't want to run IPFS node by default.
  • Opt-in should be a conscious decision (just like Widevine install or opening a Tor tab are)
  • Onboarding should be presented just-in-time

IPFS support prompt

The initial idea is for Brave to detect IPFS resource or a hint on a website and ask user if support for IPFS should be installed.

  • IPFS support would be delivered by IPFS Companion extension
  • Explicit opt-in should happen over a flow similar to Widevine (screenshot), but text about IPFS will be more friendly and educational
    • After IPFS Companion install is successful, the tab that triggered it gets reloaded
    • UX around caching negative decision per site could be the same

IPFS hints

CID (content identifier in IPFS) spec is here, it can be validated to remove false-positives.

Good candidates for IPFS hints that could be detected by Brave itself (very light on resources):

  • HTTP request for IPFS resource:
  • HTTP response headers including x-ipfs-path
    (best-effort way to detect DNSLinked sites without expensive lookups)
  • JS on a website making a getter call for window.ipfs (or window.ipfs.enable() call itself)
    (reliable signal website could opportunistically use native ipfs support, similar to window.ethereum and MetaMask)

Potentially more expensive hint is to check DNS of every visited domain for TXT record indicating presence of DNSLink (removes the need for initial HTTP request to check for x-ipfs-path header)

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 28, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Feb 12, 2019
@bbondy
Copy link
Member

bbondy commented Jun 11, 2020

Duping to #10220
Thanks for the info above though 👍

@bbondy bbondy closed this as completed Jun 11, 2020
@bbondy bbondy added the closed/duplicate Issue has already been reported label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported feature/web3/ipfs priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

5 participants