Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Rewards panel for connected user: Rewards panel shows non-connected state #30573

Open
Miyayes opened this issue May 25, 2023 · 2 comments
Assignees
Labels
bug feature/rewards intermittent-issue needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented May 25, 2023

Rewards profile is connected to Uphold, and in a browser session where the Rewards panel was working fine. Suddenly it stopped working and broke.

Broken state involves:

  • Shows Rewards panel spinning
  • Then shows non-connected state panel
  • The big toggle doesn't work (does nothing when clicked)
  • Rewards-internals stops showing any Rewards profile data

Then rewards-internals showing no Rewards profile data:

STR

Intermittently reproducible.

I reproduced it by just going to different websites and channels, then clicking the Rewards panel really fast on each one. I was trying to go through many different creators to see their contribution banners, and then this suddenly happened.

A relaunch of the browser immediately fixed the problem.

Evidence

Kapture.2023-05-25.at.12.08.23.mp4

image

Brave 1.53.63 Chromium: 114.0.5735.26 (Official Build) nightly (x86_64)
Revision 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS macOS Version 13.4 (Build 22F66)
JavaScript V8 11.4.183.7
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36

cc: @LaurenWags @GeetaSarvadnya

@Miyayes
Copy link
Collaborator Author

Miyayes commented Jul 13, 2023

I reproduced this again naturally in:

Brave 1.52.130 Chromium: 114.0.5735.198 (Official Build) (x86_64)
Revision c3029382d11c5f499e4fc317353a43d411a5ce1c-refs/branch-heads/5735@{#1394}
OS macOS Version 13.4.1 (Build 22F82)

@zenparsing
Copy link

zenparsing commented Jul 13, 2023

@Miyayes #30680 (in 1.58) may help with this, to the extent that the error state should fix itself without restart.

@Miyayes Miyayes added intermittent-issue priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/rewards intermittent-issue needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

2 participants