Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf degradation: private_footprint_size/load_chrome on v1.54.45 #30937

Closed
atuchin-m opened this issue Jun 9, 2023 · 5 comments · Fixed by brave/brave-core#18855
Closed

Perf degradation: private_footprint_size/load_chrome on v1.54.45 #30937

atuchin-m opened this issue Jun 9, 2023 · 5 comments · Fixed by brave/brave-core#18855
Assignees
@atuchin-m
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop perf QA/No release-notes/exclude
Milestone
1.57.x - Release

Comments

@atuchin-m
Copy link
Contributor

atuchin-m commented Jun 9, 2023 •
edited
Loading

The dashboard detected that on v1.54.45 browser started to consume +64MB memory in loading about:blank test.

Link to the dashboard: https://brave-perf-dashboard.appspot.com/report?sid=05261e56d9d86043a8af01474df79cd9c9ecb0adf2d4071d914178c62fac17d6
image
@atuchin-m atuchin-m added perf OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 9, 2023
@atuchin-m atuchin-m self-assigned this Jun 9, 2023
@atuchin-m
Copy link
Contributor Author

We still don't have recent mac CI builds yet (the last ones are v1.54.43).

The issue is connected to the number of process:
image

browse_news subset is also affected.

@atuchin-m
Copy link
Contributor Author

Griffin config doesn't affect the issue (it is reproducible with empty Griffin config)

@atuchin-m atuchin-m changed the title Perf degradation private_footprint_size/load_chrome on v1.54.5 Perf degradation private_footprint_size/load_chrome on v1.54.45 Jun 9, 2023
@atuchin-m atuchin-m changed the title Perf degradation private_footprint_size/load_chrome on v1.54.45 Perf degradation: private_footprint_size/load_chrome on v1.54.45 Jun 9, 2023
@atuchin-m
Copy link
Contributor Author

Tracing analyses shows that the extra processes are Data Decode Service instances:
image

@atuchin-m
Copy link
Contributor Author

Commit range: brave/brave-core@v1.54.44...v1.54.45

@atuchin-m
Copy link
Contributor Author

Connected issue: #30940

@petemill petemill mentioned this issue Jun 11, 2023
Merged
25 tasks
@atuchin-m atuchin-m mentioned this issue Jun 12, 2023
Closed
@petemill petemill added the QA/No label Jun 13, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atuchin-m atuchin-m

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop perf QA/No release-notes/exclude
Projects
None yet
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

APIRequestHelper doesn't create DataDecoder until request needs parsing brave/brave-core
4 participants
@petemill @LaurenWags @brave-builds @atuchin-m