Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to #30289: Ads are not shown for ad with target url brave://settings/?search= #31155

Closed
btlechowski opened this issue Jun 20, 2023 · 1 comment

Comments

@btlechowski
Copy link

Follow up to #30289

Ads are not shown

Steps to Reproduce

  1. Clean profile
  2. Use ads catalog that has ad with chrome://settings/?search=ipfs or brave://settings/?search=ipfs
  3. Enable rewards and ads
  4. Trigger the ad with chrome://settings/?search=ipfs or brave://settings/?search=ipfs

Actual result:

Ad is not shown

Expected result:

Ad is shown

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.53.99 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Ubuntu 18.04 LTS

cc @tmancey @aseren

@btlechowski btlechowski changed the title Follow up to #30289: Ads are not shown for brave://settings/?search= Follow up to #30289: Ads are not shown for ad with target url brave://settings/?search= Jun 20, 2023
@tmancey
Copy link
Contributor

tmancey commented Jun 21, 2023

@btlechowski by design we only support chrome://settings/search?search=ipfs or brave://settings/search?search=ipfs. I have updated the test plan in the PR. Thanks

@tmancey tmancey closed this as completed Jun 21, 2023
@tmancey tmancey self-assigned this Jun 21, 2023
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants