Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Import/Export bookmarks" strings not translated to other languages #31176

Closed
hffvld opened this issue Jun 20, 2023 · 2 comments · Fixed by brave/brave-core#19078
Closed

"Import/Export bookmarks" strings not translated to other languages #31176

hffvld opened this issue Jun 20, 2023 · 2 comments · Fixed by brave/brave-core#19078

Comments

@hffvld
Copy link
Contributor

hffvld commented Jun 20, 2023

Description

Import bookmarks and Export bookmarks are not translated into other languages.

Steps to reproduce

  1. Launch Brave 1.53.x
  2. Three-dot menu > Bookmarks
  3. Change device language in device settings
  4. In Brave on the Bookmarks screen tap Three-dot menu in the top right corner > Observe

Actual result

Import bookmarks and Export bookmarks on the Bookmarks screen are not translated into other languages.

English German Russian Japanese
1 2 3 4

Expected result

Import bookmarks and Export bookmarks must be translated into other languages.

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 7 (phone)
  • Android version: Android 14 [panther_beta-user 14 UPB3.230519.014 release-keys]

Brave version

Brave build: 1.53.100
Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision: fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@kjozwiak
Copy link
Member

The above requires 1.53.107 or higher for 1.53.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 12, 2023
@hffvld
Copy link
Contributor Author

hffvld commented Jul 12, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 UPB4.230623.005 release-keys]
Brave build: 1.56.3
Chromium: 115.0.5790.75 (Official Build) (64-bit)
Revision: 3433e4d513e8454ba0243deea3d53693661dc0c3-refs/branch-heads/5790@{#1430}

STEPS:

  1. Launch Brave
  2. Three-dot menu > Bookmarks
  3. Change device language in device settings
  4. In Brave on the Bookmarks screen tap Three-dot menu in the top right corner > Verify

ACTUAL RESULTS:

  • Verified Import bookmarks and Export bookmarks on the Bookmarks screen are not translated into other languages.

German

1 2 3
1 2 3

Spanish

1 2 3
1 2 3

French

1 2 3
1 2 3

Japanise

1 2 3
1 2 3

Russian

1 2 3
1 2 3

Hebrew

1 2 3
1 2 3

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants