Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization to the IPNS using Brave Wallet #32302

Closed
cypt4 opened this issue Aug 16, 2023 · 1 comment
Closed

Authorization to the IPNS using Brave Wallet #32302

cypt4 opened this issue Aug 16, 2023 · 1 comment
Labels
closed/wontfix feature/web3/ipfs feature/web3/wallet/core needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@cypt4
Copy link

cypt4 commented Aug 16, 2023

PL working on some extensions that would be able to post UGC to the IPNS network.
This issue if for researching how we can use Brave Wallet for user authorization, so user could restore his access to the content he published before.
For example we could generate master key using mnemonic, and then do smth like approach we have in HD keyrings to generate related keys similar to wallet accounts.
We can use mixture of mnemonic, extension id(origin), folder name, article title and index to derive IPNS key.

Also we should understand how granting access should work for extensions, since once IPNS key added to the Kubo it will be available to all extensions which have access to local Kubo node. So such extensions could identify wallet users by accessing public IPNS keys even if brave wallet is locked.
cc @kylehickinson

ATM Extensions are working with the local node using WebRequest API to modify request headers(to bypass origin check) and scanning localhost if it runs IPFS node.
Probably we should implement IPFS publish API instead with origin check policy and authorization. Or we could just stay with legacy for the MVP but add some explicit warning about deriving wallet keys from the seed.

@cypt4 cypt4 added this to Web3 Aug 16, 2023
@cypt4 cypt4 added needs-investigation A bug not 100% confirmed/fixed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Aug 17, 2023
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Aug 18, 2023
@jamesmudgett jamesmudgett added the priority/P4 Planned work. We expect to get to it "soon". label Aug 18, 2023
@vadimstruts
Copy link
Collaborator

The IPFS local node and scheme has been deprecated

@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/wontfix feature/web3/ipfs feature/web3/wallet/core needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
Archived in project
Development

No branches or pull requests

4 participants