Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unified adblock list catalog #32482

Closed
antonok-edm opened this issue Aug 23, 2023 · 2 comments · Fixed by brave/brave-core#19946
Closed

Implement unified adblock list catalog #32482

antonok-edm opened this issue Aug 23, 2023 · 2 comments · Fixed by brave/brave-core#19946
Assignees
Labels
dev-concern feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA/Test-All-Platforms release-notes/exclude

Comments

@antonok-edm
Copy link
Collaborator

antonok-edm commented Aug 23, 2023

The adblock lists we use in Brave are organized here. We've served regional.json directly from the component updater for a fairly long time. More recently, the format of default.json was updated to match regional.json, allowing them to share codepaths.

The final step of this approach will be to merge the two catalogs together. We can use new fields in each entry to specify additional information about the lists. To begin with, that information is:

  • should they be displayed in brave://settings/shields/filters as regional lists
  • should they be enabled by default
  • should first-party heuristics be applied to rules from the list

The benefit of this change will be the ability to add the following as well:

  • what scriptlet permissions should be granted to rules from the list

See also

brave/adblock-resources#130
brave/brave-core-crx-packager#687

@LaurenWags
Copy link
Member

LaurenWags commented Oct 9, 2023

Labeling as QA/Blocked for now, as it looks like this will be reverted via brave/brave-core#20459 which has been requested for uplift to 1.60.x.

Once reverted we can QA/No this one unless @kjozwiak @rebron think otherwise 👍🏻

@kjozwiak
Copy link
Member

Labelling as QA/No and removing QA/Blocked now that the above has been reverted from master & 1.60.x via brave/brave-core#20442 & brave/brave-core#20459.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-concern feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA/Test-All-Platforms release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants