Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync "No internet connection" error dialog should be general error dialog #3278

Closed
sudokai opened this issue Feb 8, 2019 · 3 comments · Fixed by brave/brave-core#1643
Closed
Assignees
Labels
feature/sync needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Linux QA Pass-Linux QA/Yes release-notes/include

Comments

@sudokai
Copy link

sudokai commented Feb 8, 2019

Description

On Linux, Brave Sync shows the error message "No internet connection. Please try again when your connection is available." even though there is a working internet connection.

Steps to Reproduce

  1. Sync.
  2. Start a new Sync Chain
  3. "No internet connection. Please try again when your connection is available."

Actual result:

"No internet connection. Please try again when your connection is available."

Expected result:

Sync works.

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.59.35 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? I don't know.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Is the issue reproducible on the latest version of Chrome? No
@srirambv
Copy link
Contributor

srirambv commented Feb 9, 2019

Does this happen even after relaunching browser? Could you try launching via terminal and see if it logs any error when you see this?

@srirambv srirambv added feature/sync OS/Linux needs-more-info The report requires more detail before we can decide what to do with this issue. labels Feb 9, 2019
@AlexeyBarabash AlexeyBarabash self-assigned this Feb 11, 2019
@mrose17
Copy link
Member

mrose17 commented Feb 11, 2019

When i re-launched the browser, the problem went away.

If i leave the sync chain, restart the browser, and then enter the code, it works.

good luck debugging this!

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 4, 2019

Verification passed on

Brave 0.61.41 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux mint

image

@rebron rebron changed the title No internet connection. Please try again when your connection is available. update Sync "No internet connection" error dialog to general error dialog Mar 5, 2019
@rebron rebron changed the title update Sync "No internet connection" error dialog to general error dialog sync "No internet connection" error dialog should be general error dialog Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/sync needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Linux QA Pass-Linux QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants