[Android] YT Improvements: Default video quality settings

[timchilds]

Description

See Default video quality settings (cellular vs. wifi) and Requirements sections here:
https://bravesoftware.slack.com/archives/CELA35G5S/p1694106384308469?thread_ts=1671572756.471319&cid=CELA35G5S

06/13 Update

Updated requirements based on slack conversation:

• Default to Allow over Wi-Fi
• When On or Allow over Wi-Fi = choose 720p resolution (or the highest available below 720p).
• When Off = yt will decide resolution or user can change to max via yt player settings (which could be 4k).

New setting copy:

Toggle
Title: High Definition Playback
Subtitle: Enables HD-quality resolution when available

Screen
Header: HD Quality Settings
Note: Video quality above HD can be enabled via the youtube.com player
^^ show this note below the on/wifi/off radio buttons

[timchilds]

Designs:
https://www.figma.com/file/eQclVYFfDpTgztKDCq9ROk/Youtube-Improvements?type=design&node-id=230%3A11489&mode=design&t=NMO8ThgjvQgwtHME-1

[timchilds]

Updated requirements based on slack conversation:

• Default to Allow over Wi-Fi cc @tapanmodh in case you missed this update on slack.
• When On or Allow over Wi-Fi = choose 720p resolution (or the highest available below 720p).
• When Off = yt will decide resolution or user can change to max via yt player settings (which could be 4k).

New setting copy:

1st Screen

• Title: High Definition Playback
• Subtitle: Enables HD quality resolution when available.

2nd Screen

• Header: HD Quality Settings
• Note: Video quality above HD can be enabled via the youtube.com player. show this note below the on/wifi/off radio buttons

@rmcfadden3 please review the copy when you have time.

cc @anthonypkeane @deeppandya @tapanmodh

[rmcfadden3]

Looks good overall. Few minor things:

• I believe we need capitalization for Up Next and End Card, as those are branded features within YouTube. So like Blocks the Up Next and End Card elements on youtube.com
• Need title case on the Block Distracting Elements section header (since this is iOS)
• Need serial comma on the Block Distracting Elements body copy. So like Blocks the sign in, menu, comments, and video info elements on youtube.com
• The body for Enable Background Audio could use some commas. Probably like this: Allows audio to play when you switch to another tab in Brave or another app, or when your device screen is off
• Since we're clearly talking about Brave, should the Widevine one end with …media content in Brave rather than …media content in the browser ?

Also, is there a reason for the inconsistent punctuation? Some of these descriptions have periods, while others do not. I'm okay either way, as long as we're consistent. Perhaps, since 2 of these end with youtube.com we should just go with no periods throughout.

[timchilds]

@rmcfadden3 we can address your concerns about the already live features in another GH issue.

I was referring to this copy:

1st Screen
Title: High Definition Playback
Subtitle: Enables HD quality resolution when available.

2nd Screen
Header: HD Quality Settings
Note: Video quality above HD can be enabled via the youtube.com player. show this note below the on/wifi/off radio buttons.

[rmcfadden3]

@rmcfadden3 we can address your concerns about the already live features in another GH issue.

I was referring to this copy:

1st Screen
Title: High Definition Playback
Subtitle: Enables HD quality resolution when available.
2nd Screen
Header: HD Quality Settings
Note: Video quality above HD can be enabled via the youtube.com player. show this note below the on/wifi/off radio buttons.

Seems alright. Just need a hyphen in first subtitle (HD-quality rather than HD quality). And then, note my comment above about punctuation: need to be consistent, so can probably remove the periods from both of your new subtitles here.

[timchilds]

Thanks @rmcfadden3.

@deeppandya @tapanmodh final copy:

Title: High Definition Playback
Subtitle: Enables HD-quality resolution when available

Header: HD Quality Settings
Note: Video quality above HD can be enabled via the youtube.com player
^^ show this note below the on/wifi/off radio buttons