Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay in loading page objects - slight performance degrade on 0.60.x #3306

Closed
GeetaSarvadnya opened this issue Feb 11, 2019 · 7 comments
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 11, 2019

Description

Due to delay in loading page objects, Allow contribution to videos checkbox is unchecked by default. When we refresh the brave://rewards page or visit other pages and navigate back to auto contribution settings page, the Allow contribution to videos checkbox is checked automatically.

Steps to Reproduce

  1. Clean profile 0.60.25
  2. Enable rewards through rewards panel
  3. Open Auto contribution settings page

Actual result:

Allow contribution to videos checkbox is unchecked by default
unchecked by default

Expected result:

Allow contribution to videos checkbox should be checked by default

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.60.25 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 10

Reproducible on current release: no

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? na
  • Is the issue reproducible on the latest version of Chrome? na

Additional Information

@brave/legacy_qa @NejcZdovc

@GeetaSarvadnya GeetaSarvadnya added bug feature/rewards priority/P4 Planned work. We expect to get to it "soon". QA/Yes regression labels Feb 11, 2019
@GeetaSarvadnya GeetaSarvadnya changed the title Allow contribution to videos is unchecked by default Allow contribution to videos settings is unchecked by default Feb 11, 2019
@kjozwiak
Copy link
Member

@GeetaSarvadnya can you reproduce this every time on a clean profile? I tried reproducing the above on the following platforms:

  • Win 10 x64 VM using 0.60.26 Chromium: 72.0.3626.96 - Couldn't reproduce
  • macOS 10.14.2 x64 using 0.60.26 Chromium: 72.0.3626.96 - Couldn't reproduce
  • Win 10 x64 (psychical machine) using 0.60.26 Chromium: 72.0.3626.96 - Couldn't reproduce

For the above, I launched brave using a new profile and ensured that Allow contribution to videos was enabled by default when enabling Rewards via the Rewards panel and through brave://rewards.

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Feb 11, 2019

@kjozwiak I am able to reproduce the issue on 0.60.26 Continuously. This issue is happening due to delay in loading the page objects. If i keep open the auto contribute settings page and visit other pages, issues gets resolved automatically.

0 60 26_allow auto contribution is unchecked by default

Released version: 0.59.35 - No performance degrade

released version

But, on release version this delay is not there. I guess there is some performance degrade on 0.60.26

@GeetaSarvadnya GeetaSarvadnya changed the title Allow contribution to videos settings is unchecked by default Delay in loading page objects - slight performance degrade on 0.60.x Feb 11, 2019
@NejcZdovc
Copy link
Contributor

I think something else is going, don't think it's related to performance

@kjozwiak
Copy link
Member

STR seem easy enough but I haven't ran into the above on a VM nor my psychical machine. Wonder what the difference between @GeetaSarvadnya's machine/STR and mine are.

@LaurenWags can you see if you can reproduce this when you have some time?

@LaurenWags
Copy link
Member

I have not been able to reproduce this - tried with below build. Will keep an eye out for it.

Brave 0.60.48 Chromium: 72.0.3626.121 (Official Build) (64-bit)
Revision da3787ba355f18db7db52abf75c42afb408d656f-refs/branch-heads/3626@{#883}
OS Mac OS X

@kjozwiak
Copy link
Member

@GeetaSarvadnya can you still reproduce this?

@GeetaSarvadnya
Copy link
Author

Unable to reproduce the issue on the current Release (0.63.48) and Beta build (0.64.60)

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone May 5, 2019
@kjozwiak kjozwiak removed this from the Dupe / Invalid / Not actionable milestone May 7, 2019
@kjozwiak kjozwiak added closed/invalid and removed QA/Yes bug feature/rewards priority/P4 Planned work. We expect to get to it "soon". regression labels May 7, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants