Display origin property in SIWE more effectively

[kdenhartog]

Currently the Origin property in the SIWE panel will display JSON. This will likely lead to in-effective wrapping of the host such that it's not clear who's making the request or the request could be obfuscated in a way to trick the user.

To address this we should display this like a normal URL using bold text for the eTLD+1 similar to what we do in many other wallet panels.

To address this we'll likely need an update to the property being returned from core and then we'll need subsequent UI changes to display it properly.

cc @brave/ios to make sure you get a subsequent issue in for this as well.

[nuo-xu]

This is the current request panel for SIWE. We are displaying the correct eTLD+1
https://github.com/brave/brave-browser/assets/1187676/3c6b6d3e-168a-4d85-bd0b-52fbc8b1719c
For SIWE new UI, we will address in brave/brave-ios#7827

[kdenhartog]

Thanks, I just started following that issue. This is likely going to require core changes first, but I suspect it will be done around similar time to the iOS changes.

[StephenHeaps]

@kdenhartog I have the initial work for iOS to allow compilation after core changes (so iOS team can code review core PRs on master) available in our brave-core-1.60.x working branch. The initial work only implements the SIWE error view, but uses existing signature request view for SIWE (will be updated in brave/brave-ios#7827).

[kdenhartog]

Are you displaying the eTLD+1 as the origin here? Android was looking at doing that but ports/schemes were getting dropped which could become an issue in very rare circumstances (e.g. wss:// hosts different content or different port hosts different content on a shared site domain like github.io).

This is mainly about displaying the additional panels on the left side. What you've got on the right wouldn't be affected by this issue and LGTM.

[kdenhartog]

After discussing this further in iOS it appears that if we use the origin_spec which will return the port if it's non standard here. https://bravesoftware.slack.com/archives/C04JJNFRPK7/p1698269920543509