Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clock in new tab page showing different time compared to Mac OS clock #33644

Open
mastazi opened this issue Oct 16, 2023 · 1 comment
Open

Clock in new tab page showing different time compared to Mac OS clock #33644

mastazi opened this issue Oct 16, 2023 · 1 comment

Comments

@mastazi
Copy link

mastazi commented Oct 16, 2023

Description

I am on Mac OS Sonoma 14.0. I am in timezone Australia/Sydney. My OS says it's 1pm (which is correct) but the clock in Brave's new tab page says it's noon (which is not correct).

Screenshot 2023-10-16 at 1 08 07 pm

Steps to Reproduce

  1. Install Brave on a Mac, set the Mac to timezone Australia/Sydney
  2. Open a new tab
  3. check the clock in the new tab and compare to the OS clock.

Actual result:

The clock in the new tab and the OS clock show different times.

Expected result:

The clock in the new tab and the OS clock should show the same time.

Reproduces how often:

No Steps to reproduce

Brave version (brave://version info)

1.59.117 Chromium: 118.0.5993.70 (Official Build) (arm64)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No (Shields are always disabled in new tab page)
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A (new tab page is different in Chrome)

Miscellaneous Information:

Mac OS Sonoma 14.0

@bsclifton
Copy link
Member

bsclifton commented Mar 6, 2024

Related #7951 - using system time would solve the issue for new tab page

@mastazi the time shown in new tab page clock is coming from the JavaScript environment (via V8 ICU). This means any web pages you visit would be having the wrong time too. Can you confirm? (ex: timestamps on GitHub)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants