Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS crash logs seem to have corruption in Rust code #34045

Closed
bsclifton opened this issue Nov 1, 2023 · 1 comment
Closed

iOS crash logs seem to have corruption in Rust code #34045

bsclifton opened this issue Nov 1, 2023 · 1 comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.

Comments

@bsclifton
Copy link
Member

Description

Seems to have started with 1.57.x - but iOS crash logs are having rust symbols and not showing the true error.

Here's an example by @kylehickinson:

Thread 28 Crashed:
0   BraveCore                     	0x0000000105d21b54 gimli::read::unit::UnitHeader$LT$R$C$Offset$GT$::address_size::hd773f6fd2bfe7275 + 27588
1   BraveCore                     	0x0000000105d21a98 gimli::read::unit::UnitHeader$LT$R$C$Offset$GT$::address_size::hd773f6fd2bfe7275 + 27400
2   BraveCore                     	0x0000000105d21b70 gimli::read::unit::UnitHeader$LT$R$C$Offset$GT$::address_size::hd773f6fd2bfe7275 + 27616
3   BraveCore                     	0x0000000105d23550 gimli::read::unit::UnitHeader$LT$R$C$Offset$GT$::address_size::hd773f6fd2bfe7275 + 34240
4   BraveCore                     	0x0000000105d837d0 brave_wallet::EthereumProviderImpl::~EthereumProviderImpl() + 220 (ethereum_provider_impl.cc:139)
5   BraveCore                     	0x0000000105d83840 brave_wallet::EthereumProviderImpl::~EthereumProviderImpl() + 12 (ethereum_provider_impl.cc:135)

In this particular instance, there is a CHECK() failing and it's masked by the gimli::read::unit::UnitHeader lines.

Per @kylehickinson - the crash is pulled in from Xcode and symbolized using symbols uploaded with the build on AppStore Connect

We're having trouble narrowing down root cause for brave/brave-ios#8334 - there is an attempted fix, but because the call stack is corrupt, it's hard to know the exact condition it's failing on.

@bsclifton bsclifton added crash OS/iOS Fixes related to iOS browser functionality labels Nov 1, 2023
@kylehickinson kylehickinson added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 14, 2023
@iccub
Copy link

iccub commented Dec 8, 2023

Closing. Looks like Apple fixed something on their end and the logs are visible again

@kylehickinson kylehickinson closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2023
@kylehickinson kylehickinson added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. and removed crash priority/P2 A bad problem. We might uplift this to the next planned release. OS/iOS Fixes related to iOS browser functionality labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.
Projects
None yet
Development

No branches or pull requests

3 participants