Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe sign panel should display custom recipients #34829

Open
kdenhartog opened this issue Dec 12, 2023 · 2 comments
Open

Safe sign panel should display custom recipients #34829

kdenhartog opened this issue Dec 12, 2023 · 2 comments
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/Yes release-notes/include security

Comments

@kdenhartog
Copy link
Member

Screenshot 2023-12-12 at 3 29 29 PM

Currently this doesn't display a custom recipient which is necessary to be sure the money is going to the right person

@kdenhartog kdenhartog added security QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop feature/web3/wallet/swap design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Dec 12, 2023
@kdenhartog
Copy link
Member Author

Here's how @StephenHeaps is planning to do it in iOS by reusing the sign request panels. This seems like a reasonable approach here as well:

image
image

@StephenHeaps
Copy link

I am following this issue, but if core support is added for storing the custom recipient on CoW Swap transactions then iOS will need an update as well to pass the custom recipient address to the safer sign UI. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/Yes release-notes/include security
Projects
None yet
Development

No branches or pull requests

2 participants