Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tor not working till browser restart if page is opened just after clean install #3512

Closed
btlechowski opened this issue Feb 27, 2019 · 5 comments

Comments

@btlechowski
Copy link

Follow up from #3058

Steps to Reproduce

  1. Clean install (make sure that profile does not exists)
  2. Immediately after Brave is launched open https://check.torproject.org/ in Tor Window
  3. Close Tor Window
  4. Open Tor Window and open a page

Actual result:

Page is not opened.
Error page is always shown
Tor is not initialized.

Note: browser restart fixes this issue

Expected result:

Tor is initialized

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Verification passed on

Brave 0.61.38 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

cc @brave/legacy_qa @tomlowenthal @riastradh-brave

@tildelowengrimm tildelowengrimm added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 27, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 4, 2019

Reproduced on Linux 0.61.41 - Linux Mint

Brave 0.61.41 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux Mint

@tildelowengrimm tildelowengrimm added the needs-investigation A bug not 100% confirmed/fixed label Jul 16, 2019
@btlechowski
Copy link
Author

Still reproducible.

Brave 0.67.111 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 7 Service Pack 1 (Build 7601.24494)

@riastradh-brave
Copy link
Contributor

This happens if you type fast enough to beat the component updater downloading the tor component. The tor component updater initializes the tor executable path only after the component is downloaded, but the only place that we choose to launch tor is when we construct the TorProfileServiceImpl -- which may happen before the tor component has been downloaded.

Resolution: Maybe we can teach BraveTorClientUpdater::OnComponentReady to notify the TorProfileServiceImpl that it can launch tor now.

@btlechowski
Copy link
Author

Probably fixed by brave/brave-core#7069

Added it to 1.19.x milestone so it can be retested.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 22, 2020

Verification passed on


Brave | 1.19.66 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2004 (Build 19041.685)


Verification passed on

Brave 1.19.73 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Ubuntu 18.04 LTS

Verified test plan from the description and brave/brave-core#7069.
Rest of testing done in #12429 (comment)


Verified passed with

Brave | 1.19.79 Chromium: 87.0.4280.141 (Official Build) dev (x86_64)
-- | --
Revision | 9f05d1d9ee7483a73e9fe91ddcb8274ebcec9d7f-refs/branch-heads/4280@{#2007}
OS | macOS Version 10.15.7 (Build 19H15)

Verified STR from description.
Additional testing notes can be found under #12429 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants